[semantic-arc-opts] Create an explicit composition type for "ownership phi operands". #32172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p phi operands". This is letting me refactor the implementation of every place that I work with branches as "ownership phi operands" to instead work with OwnershipPhiOperand. In a future commit, I am going to use this to add support for optimizing structs and tuples that have multiple owned incoming values. <rdar://problem/63950481>
|
@swift-ci test |
|
Build failed |
|
Known sand box view |
|
@swift-ci test OS X platform |
gottesmm
commented
Jun 4, 2020
| case Kind::Branch: { | ||
| auto *br = cast<BranchInst>(getInst()); | ||
| unsigned opNum = getOperandNumber(); | ||
| return llvm::all_of( |
There was a problem hiding this comment.
One thing to be aware of is that when I add instructions like struct/tuple here, I am going to be just returning getInst() essentially.
|
FYI, again: this is just a pure refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is letting me refactor the implementation of every place that I work with
branches as "ownership phi operands" to instead work with
OwnershipPhiOperand. In a future commit, I am going to use this to add support
for optimizing structs and tuples that have multiple owned incoming values.
rdar://problem/63950481