[semantic-arc-opts] Teach semantic-arc-opts how to handle structs with multiple non-trivial values. #32173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
@swift-ci benchmark |
|
Build failed |
Performance: -O
Code size: -OPerformance: -Osize
Code size: -OsizePerformance: -Onone
Code size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview |
|
@swift-ci test OS X platform |
…h multiple non-trivial values. Just like br inst, structs are phis in the ownership graph that one can induce on top of the def-use graph. In this commit, I basically fill in the relevant blanks in the ADT for such phis for struct so that the optimization for branches is generalized onto structs. <rdar://problem/63950481>
|
The Debug failure wasn't my patch: |
gottesmm
force-pushed
the
pr-5e5960b7d932ff90a03c93f1ba6ac111c52d1157
branch
from
dc40712 to
3cb33ac
Compare
|
Just did a rebase. |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like br inst, structs are phis in the ownership graph that one can induce
on top of the def-use graph. In this commit, I basically fill in the relevant
blanks in the ADT for such phis for struct so that the optimization for branches
is generalized onto structs.
rdar://problem/63950481
NOTE: The first commit is from #32172. I am using the original implementation to check the correctness of the refactor before I land this.