Skip to content

[semantic-arc-opts] Teach semantic-arc-opts how to handle tuples with multiple non-trivial operands. #32179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Jun 4, 2020

This is the tuple version of #32173.
rdar://problem/63950481

@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 4, 2020

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 4, 2020

@swift-ci benchmark

@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 4, 2020

@swift-ci test source compatibility

@swift-ci
Copy link
Contributor

swift-ci commented Jun 4, 2020

Performance: -O

Improvement OLD NEW DELTA RATIO
String.data.LargeUnicode 127 115 -9.4% 1.10x (?)
FlattenListFlatMap 5277 4825 -8.6% 1.09x (?)

Code size: -O

Performance: -Osize

Improvement OLD NEW DELTA RATIO
PrefixAnySeqCRangeIterLazy 176 159 -9.7% 1.11x (?)
PrefixAnySeqCntRangeLazy 176 159 -9.7% 1.11x (?)

Code size: -Osize

Performance: -Onone

Regression OLD NEW DELTA RATIO
String.data.LargeUnicode 110 126 +14.5% 0.87x (?)
 
Improvement OLD NEW DELTA RATIO
UTF8Decode_InitFromCustom_contiguous_ascii_as_ascii 469 427 -9.0% 1.10x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@swift-ci
Copy link
Contributor

swift-ci commented Jun 4, 2020

Build failed
Swift Test OS X Platform
Git Sha - f2aa8d4649de29052744182fc15fd55afa661c5b

@swift-ci
Copy link
Contributor

swift-ci commented Jun 4, 2020

Build failed
Swift Test Linux Platform
Git Sha - f2aa8d4649de29052744182fc15fd55afa661c5b

@gottesmm gottesmm requested a review from atrick June 5, 2020 20:31
@gottesmm gottesmm force-pushed the pr-1be69dcd1c3376a6b0ecdd3afe8df66b67ba01b0 branch from f2aa8d4 to a207987 Compare June 5, 2020 20:31
@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 5, 2020

@swift-ci test

3 similar comments
@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 5, 2020

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 5, 2020

@swift-ci test

@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 5, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 5, 2020

Build failed
Swift Test OS X Platform
Git Sha - a207987328f0767ee3a1269257f58ce0a6853376

@swift-ci
Copy link
Contributor

swift-ci commented Jun 5, 2020

Build failed
Swift Test OS X Platform
Git Sha - a207987328f0767ee3a1269257f58ce0a6853376

@swift-ci
Copy link
Contributor

swift-ci commented Jun 5, 2020

Build failed
Swift Test Linux Platform
Git Sha - a207987328f0767ee3a1269257f58ce0a6853376

… multiple non-trivial operands.

<rdar://problem/63950481>
@gottesmm gottesmm force-pushed the pr-1be69dcd1c3376a6b0ecdd3afe8df66b67ba01b0 branch from a207987 to 142aa42 Compare June 6, 2020 02:56
@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 6, 2020

@swift-ci test

1 similar comment
@gottesmm
Copy link
Contributor Author

gottesmm commented Jun 6, 2020

@swift-ci test

@gottesmm gottesmm merged commit 6b80da6 into swiftlang:master Jun 8, 2020
@gottesmm gottesmm deleted the pr-1be69dcd1c3376a6b0ecdd3afe8df66b67ba01b0 branch June 8, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants