Skip to content

[nfc] Enable member function templates silgen test. #35547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zoecarver
Copy link
Contributor

This test was disabled until #30630 (support calling C++ constructors) landed. That patch landed a while ago, so this test should be enabled.

@zoecarver zoecarver added the c++ interop Feature: Interoperability with C++ label Jan 22, 2021
@zoecarver zoecarver requested review from hlopko and gribozavr January 22, 2021 01:10
@zoecarver
Copy link
Contributor Author

I'm going to merge this as soon as the tests pass. If someone has an objection, it will be very easy to revert (but I highly doubt that anyone will object).

@zoecarver
Copy link
Contributor Author

@swift-ci please smoke test.

c4da497 (swiftlang#35416) changed the names of several member templates, this
commit fixes the disabled test to use those new names.
This test was dissabled until swiftlang#30630 (support calling C++ constructors)
landed. That patch landed a while ago, so this test should be enabled.
@zoecarver zoecarver force-pushed the cxx/enable-member-templates-silgen-test branch from 44a9d31 to 13ff0d6 Compare January 31, 2021 20:53
@zoecarver
Copy link
Contributor Author

@swift-ci please smoke test.

@zoecarver zoecarver merged commit 06cd5bc into swiftlang:main Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants