Skip to content

[Threading][UnitTests] Don't use threads in the unit test in no-threads mode. #59403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Threading][UnitTests] Don't use threads in the unit test in no-threads mode. #59403

wants to merge 1 commit into from

Conversation

al45tair
Copy link
Contributor

If the threading package is set to "none", don't actually use threads in the unit tests.

rdar://95011060

@al45tair
Copy link
Contributor Author

This should fix the failure we saw in #59365

@al45tair al45tair mentioned this pull request Jun 13, 2022
Merged
@al45tair
[Threading][UnitTests] Don't use threads in the unit test in no-threa…
cdb2418 
…ds mode.

If the threading package is set to "none", don't actually use threads in the
unit tests.

rdar://95011060
@al45tair
Copy link
Contributor Author

@swift-ci Please smoke test

@al45tair
Copy link
Contributor Author

preset=buildbot_incremental_linux_crosscompile_wasm
@swift-ci Please test with preset Linux Platform

@kateinoigakukun
Copy link
Member

kateinoigakukun commented Jun 14, 2022 •
edited
Loading 

[ RUN      ] LazyUnsafeMutexTest.TryLockable
/home/build-user/swift/unittests/Threading/LockingHelpers.h:39: Failure
Value of: ret
  Actual: true
Expected: false

Hmm, should we keep the behavior cannot lock a locked lock in no thread impl? Or skip those tests?

@al45tair
Copy link
Contributor Author

I think we should skip those tests. It seems pointless tracking the fact that we've "locked" a lock in an un-threaded environment. Looks like I also need to turn off the ExclusiveAccess tests when threading is set to none.

@kateinoigakukun kateinoigakukun mentioned this pull request Jun 18, 2022
Merged
@al45tair
Copy link
Contributor Author

al45tair commented Jul 7, 2022

Closed in favour of #59561 (which also disables a few tests for the threading=none case).

@al45tair al45tair closed this Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@al45tair @kateinoigakukun