[Threading][test] Repair none threading tests #59561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
preset=buildbot_incremental_linux_crosscompile_wasm |
kateinoigakukun
force-pushed
the
katei/repair-none-threading-tests
branch
from
50ed98a to
b0001a9
Compare
|
preset=buildbot_incremental_linux_crosscompile_wasm |
|
@swift-ci Please smoke test |
|
@al45tair Kindly ping :) |
al45tair
reviewed
Jun 20, 2022
kateinoigakukun
force-pushed
the
katei/repair-none-threading-tests
branch
from
b0001a9 to
cb5a1a3
Compare
|
@swift-ci please smoke test |
…ds mode. If the threading package is set to "none", don't actually use threads in the unit tests. rdar://95011060
kateinoigakukun
force-pushed
the
katei/repair-none-threading-tests
branch
from
cb5a1a3 to
356156d
Compare
|
preset=buildbot_incremental_linux_crosscompile_wasm |
|
@swift-ci Please smoke test |
kateinoigakukun
force-pushed
the
katei/repair-none-threading-tests
branch
2 times, most recently
from
249d08b to
356156d
Compare
al45tair
approved these changes
Jul 7, 2022
|
Thank you for quick review 😄 |
|
😊 Thank-you for working on this — and I'm glad the threading package stuff is useful for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the all tests on no-thread based on #59403