[Macros] PluginRegistry vends 'LoadedLibraryPlugin' instead of 'void *' #64845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
commented
Apr 2, 2023
| @@ -367,33 +364,28 @@ loadExecutablePluginByName(ASTContext &ctx, Identifier moduleName) { | |||
| LoadedCompilerPlugin | |||
| CompilerPluginLoadRequest::evaluate(Evaluator &evaluator, ASTContext *ctx, | |||
| Identifier moduleName) const { | |||
| auto fs = ctx->SourceMgr.getFileSystem(); | |||
| auto &searchPathOpts = ctx->SearchPathOpts; | |||
| auto *registry = ctx->getPluginRegistry(); | |||
There was a problem hiding this comment.
Unrelated changes but these variables weren't used. I should have removed these in d8c8574
rintaro
requested review from
bnbarham
and removed request for
xedin,
slavapestov and
hborla
rintaro
force-pushed
the
macros-loadedlibraryplugin
branch
2 times, most recently
from
990d527 to
70d2964
Compare
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
macros-loadedlibraryplugin
branch
from
70d2964 to
8b9895a
Compare
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Apr 11, 2023
lib/AST/PluginRegistry.cpp
Outdated
| LoadedPluginLibraries.insert({path, lib}); | ||
| return lib; | ||
|
|
||
| storage = std::unique_ptr<LoadedLibraryPlugin>(new LoadedLibraryPlugin(lib)); |
There was a problem hiding this comment.
Can use make_unique here FWIW. But if there's no other changes I'm fine with getting this in so you don't have to re-run tests.
`LoadedLibraryPlugin` is currently just a wrapper of `void` pointer from `dlopen`. This will be convenient for abstracting platform specific dynamic linrary handling.
rintaro
force-pushed
the
macros-loadedlibraryplugin
branch
from
8b9895a to
90e1558
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoadedLibraryPluginis currently just a wrapper ofvoidpointer fromdlopen. This will be convenient for abstracting platform specific dynamic library handling.Also update
LoadedCompierPluginmaking it allvm::PointerUnion