[5.9][Macros] Track plugin dependencies #65421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LoadedLibraryPlugin` is currently just a wrapper of `void` pointer from `dlopen`. This will be convenient for abstracting platform specific dynamic linrary handling. (cherry picked from commit f99d70d)
(cherry picked from commit ace080c)
(cherry picked from commit 90e1558)
* Factor out ASTContext plugin loading to newly introduced 'PluginLoader' * Insert 'DependencyTracker' to 'PluginLoader' * Add dependencies right before loading the plugins rdar://104938481 (cherry picked from commit a551c01)
|
swiftlang/llvm-project#6720 |
DougGregor
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #65322 (and depending #64845) into
release/5.9Explanation: Plugin dependencies were not tracked in swiftdeps. Because of that, files using plugins (using macros) were not correctly rebuilt even when the plugin implementation was modified. With this change, plugin dependencies (dylib plugins and executable plugins) are tracked by normal
DependencyTrackerfacility just like module file dependencies.Scope: swiftdeps when plugins are used
Risk: Low-Mid. This adds new elements to existing dependency tracking facility
Testing: Added regression test case for checking plugins are tracked by
swiftdepsfilesIssue: rdar://104938481
Reviewer: Doug Gregor (@DougGregor), Artem Chikin (@artemcm), Richard Wei (@rxwei), Alex Hoppen (@ahoppen)
llvm-project changes: swiftlang/llvm-project#6720