[5.9][Macros] Update plugin search options serialization #66724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
changed the title
|
swiftlang/llvm-project#7011 |
rintaro
force-pushed
the
5.9-macros-serialization-pluginopts
branch
from
a4adf12 to
9920533
Compare
|
Does this affect any of the LLDB deserialization code in https://github.com/apple/llvm-project/blob/e2b11c251e5ef2be08e2b10bf4f0421308dcb871/lldb/source/Plugins/TypeSystem/Swift/SwiftASTContext.cpp#L1285 ? |
|
@adrian-prantl Yes, swiftlang/llvm-project#7011 is the corresponding change. |
Iterating all options and potential file system access is not great for every plugin lookup request. Instead, lazily create a single lookup table keyed by module name. (cherry picked from commit b8a073c)
rintaro
force-pushed
the
5.9-macros-serialization-pluginopts
branch
from
9920533 to
586a746
Compare
|
swiftlang/llvm-project#7011 |
DougGregor
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #66689 and #66722 into release/5.9
-plugin-path,-load-plugin-library) are processed by the order specified in the argument list. But they were still serialized/deserialized in the module grouped by each option kind. That may have caused incorrect plugins loading. This change fix that by updating the serialization. Also, this PR includes plugin search table change which which may improve plugin search performance.