Skip to content

[Build] Skip early-* on non-darwin hosts #68091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

bnbarham
Copy link
Contributor

These builds do not work outside of darwin currently. Rather than adding the skip to all the necessary build presets, just disable in the product instead.

@bnbarham
Copy link
Contributor Author

@swift-ci please test

Copy link
Member

@finagolfin finagolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import sys is needed in the Python files, otherwise good.

@bnbarham bnbarham force-pushed the disable-early-linux branch from 2c42a38 to 97a6f3b Compare August 23, 2023 16:39
@bnbarham
Copy link
Contributor Author

import sys is needed in the Python files, otherwise good.

Yeah, just saw the failure and re-pushed.

@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test

@finagolfin
Copy link
Member

Looks like three build script tests explicitly look to see if the early swift driver output is there, so they will need to be modified too.

@bnbarham bnbarham force-pushed the disable-early-linux branch from 97a6f3b to 681c3c7 Compare August 23, 2023 18:30
@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test

These builds do not work outside of darwin currently. Rather than adding
the skip to all the necessary build presets, just disable in the product
instead.
@bnbarham bnbarham force-pushed the disable-early-linux branch from 681c3c7 to 8fbdae1 Compare August 23, 2023 18:44
@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test

@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test Linux platform

@finagolfin
Copy link
Member

Why was that linux smoke test failing? I didn't find that module.map error from the CI anywhere in the compiler source.

@bnbarham
Copy link
Contributor Author

It's in LLVM (swiftlang/llvm-project#7307). Seems that we don't run SwiftPM tests there.

@finagolfin
Copy link
Member

Ah, makes sense, as that pull you reverted was just merged a couple hours ago, whereas I was looking in an LLVM checkout from this morning.

@bnbarham
Copy link
Contributor Author

Ah, makes sense, as that pull you reverted was just merged a couple hours ago, whereas I was looking in an LLVM checkout from this morning.

Yeah, status job wasn't up to it yet either which initially confused me 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants