[5.8][Build] Skip early-* on non-darwin hosts #68092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bnbarham
commented
Aug 23, 2023
•
bnbarham
commented
- Explanation: The linux images now contain a host swift, which enables the early* products by default. But these builds don't work outside of Darwin currently, which breaks all presets that don't explicitly disable them. Rather than add these flags to all necessary presets, instead disable for all but Darwin in the products themselves.
- Scope: No-op, this brings us back to the behavior prior to having a host swift installed
- Risk: Low
- Original PR: [Build] Skip early-* on non-darwin hosts #68091
- Testing: CI (no extra tests)
bnbarham
added
🍒 release cherry pick
|
@swift-ci please test |
bnbarham
force-pushed
the
disable-early-linux-58
branch
from
6a08156 to
99d8c18
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Aug 23, 2023
These builds do not work outside of darwin currently. Rather than adding the skip to all the necessary build presets, just disable in the product instead.
bnbarham
force-pushed
the
disable-early-linux-58
branch
from
99d8c18 to
569f66d
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.