Skip to content

build: cherry-picks from main for dependencies and Windows build #69608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2023
Merged

build: cherry-picks from main for dependencies and Windows build #69608

merged 1 commit into from
Nov 4, 2023

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Nov 2, 2023

Update to using build.ps1 on release/5.10 as well to get the complete toolchain build on Windows. Switch to using update-checkout for checking out the following dependencies:

  • CURL
  • ICU
  • libxml2
  • zlib

Update the CURL dependency to 8.4.0 to match 5.9.1.

@compnerd
build: cherry-picks from main for dependencies and Windows build
60f7b57 
Update to using build.ps1 on release/5.10 as well to get the complete
toolchain build on Windows. Switch to using update-checkout for checking
out the following dependencies:
- CURL
- ICU
- libxml2
- zlib

Update the CURL dependency to 8.4.0 to match 5.9.1.
@compnerd compnerd requested a review from shahmishal November 2, 2023 14:49
@compnerd compnerd requested a review from a team as a code owner November 2, 2023 14:49
@compnerd
Copy link
Member Author

compnerd commented Nov 2, 2023

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Nov 2, 2023

This appears to be failing due to the inability to run swift.

$s013CompilerSwiftA21PluginMessageHandling0c6ToHostD0O17expandMacroResultyACSSSg_SayAA0cD0O10DiagnosticVGtcACmFWC is missing in _InternalSwiftScan.dll
$s013CompilerSwiftA21PluginMessageHandling0cD0O10DiagnosticV5FixItV6ChangeV5rangeAE13PositionRangeVvg is missing in swift-frontend.exe.

CC: @bnbarham @rintaro @DougGregor

I'm not sure what is going on here. We previously had this problem on main due to the linking between swift-syntax and LSP was done dynamically and we would hit the namespacing.

@compnerd
Copy link
Member Author

compnerd commented Nov 3, 2023

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Nov 3, 2023

@swift-ci please test

@compnerd compnerd mentioned this pull request Nov 3, 2023
Open
@shahmishal
Copy link
Member

Can you also verify this does not cause any issues for swift-corelibs-foundation for release/5.10 branch?

@compnerd compnerd mentioned this pull request Nov 3, 2023
Closed
@compnerd
Copy link
Member Author

compnerd commented Nov 3, 2023

swiftlang/swift-corelibs-foundation#4840

@compnerd
Copy link
Member Author

compnerd commented Nov 4, 2023

@shahmishal https://ci.swift.org/job/swift-corelibs-foundation-PR-Linux/307/ - seems to be good!

@shahmishal shahmishal merged commit 7ccdd47 into swiftlang:release/5.10 Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
swift 5.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compnerd @shahmishal