[DiscardingTG] Remove reabstraction thunk for () -> Void to () -> T
#70537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concurrency runtime expects discarding task operation entrypoint function not to have result type, but the current SILGen implementation generates reabstraction thunk to convert `() -> Void` to `() -> T` for the operation function. Since the `T` is always `Void` for DiscardingTG, the mismatch of result type expectation does not cause any problem on most platforms, but the signature mismatch causes a problem on WebAssembly. This patch introduces new builtin operations for creating discarding task, which always takes `() -> Void` as the operation function type.
kateinoigakukun
requested review from
ktoso,
kavon,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please test |
slavapestov
reviewed
Dec 19, 2023
There was a problem hiding this comment.
@jckarter Maybe there's a way to achieve this without a new builtin, using your reabstraction peephole logic?
|
@swift-ci test |
|
@swift-ci test |
ktoso
added
concurrency runtime
ktoso
approved these changes
Jan 9, 2024
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
…T` (swiftlang#70537) Concurrency runtime expects discarding task operation entrypoint function not to have result type, but the current SILGen implementation generates reabstraction thunk to convert `() -> Void` to `() -> T` for the operation function. Since the `T` is always `Void` for DiscardingTG, the mismatch of result type expectation does not cause any problem on most platforms, but the signature mismatch causes a problem on WebAssembly. This patch introduces new builtin operations for creating discarding task, which always takes `() -> Void` as the operation function type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrency runtime expects discarding task operation entrypoint function not to have result type, but the current SILGen implementation generates reabstraction thunk to convert
() -> Voidto() -> Tfor the operation function.Since the
Tis alwaysVoidfor DiscardingTG, the mismatch of result type expectation does not cause any problem on most platforms, but the signature mismatch causes a problem on WebAssembly.This patch introduces new builtin operations for creating discarding task, which always takes
() -> Voidas the operation function type.The issue #63060 was partially fixed by #66219, but #68793 revealed the issue again since it added extra reabstraction for the given operation closure.