[Concurrency] Fix the missing builtin guards for DiscardingTaskGroup #70837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
kavon,
hborla,
slavapestov,
xedin and
tshortli
as code owners
ktoso
force-pushed
the
wip-guard-builtin-BuiltinCreateAsyncDiscardingTaskInGroup
branch
from
692f294 to
f203571
Compare
ktoso
commented
Jan 11, 2024
| // correct 'createAsyncDiscardingTaskInGroup' when available (and a recent | ||
| // enough compiler is used). | ||
| _ = Builtin.createAsyncTaskInGroup(flags, _group, operation) | ||
| #endif |
There was a problem hiding this comment.
I think that's the right dance to do here -- the comment attempts to explain what we're doing here -- See the PR which introduced this change here: https://github.com/apple/swift/pull/70537/files#diff-9897ab704fe1b9e57499ec46e8837c683573998d299ea3cbfb64d29c4a34544aL567
So we're using what "used to work" on other platforms and old compilers, and when available, we use the "right thing".
Looks right @slavapestov @kavon ?
|
@swift-ci please smoke test |
tshortli
approved these changes
Jan 11, 2024
kateinoigakukun
approved these changes
Jan 11, 2024
|
Luckily it got caught in testing before it causes more trouble 😅 |
ktoso
deleted the
wip-guard-builtin-BuiltinCreateAsyncDiscardingTaskInGroup
branch
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Jan 11, 2024
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #70537 adjusted the way we create tasks for the discarding group by using a new builtin -- this builtin must be protected with a
#if $BuiltinCreateAsyncDiscardingTaskInGroupas otherwise we can get issues likemodule 'Builtin' has no member named 'createAsyncDiscardingTaskInGroup'when an old compiler without this builtin is used.FYI @kateinoigakukun @MaxDesiatov
Resolves rdar://120801949