Skip to content

utils: enable SPM self-hosted test suite on Windows #71349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Feb 2, 2024

This will enable the SPM test suite to be built with a self-hosted
build to ensure that we do not regress the SPM builds on Windows.

@compnerd
Copy link
Member Author

compnerd commented Feb 2, 2024

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Feb 2, 2024

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Feb 3, 2024

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

compnerd commented Feb 4, 2024

Please test with following PRs:
swiftlang/swift-package-manager#6853

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

@swift-ci please test

@al45tair
Copy link
Contributor

@swift-ci Please test Windows platform

This will enable the SPM test suite to be built with a self-hosted
build to ensure that we do not regress the SPM builds on Windows.
@compnerd compnerd changed the title Spm validation utils: enable SPM self-hosted test suite on Windows Jul 16, 2024
@bkhouri
Copy link
Contributor

bkhouri commented Mar 14, 2025

Thanks for this PR @compnerd . I was planning on tackling this once I finished swiftlang/swift-package-manager#8176. But I'm happy to see you progressing on this :)

Copy link
Contributor

@bkhouri bkhouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, though I'm not familiar enough with the utils/build-windows-toolchain.bat to approve this PR.

@compnerd
Copy link
Member Author

@bkhouri that sounds great! I think that I have enough on my plate and would love to get some help :)

@bkhouri
Copy link
Contributor

bkhouri commented Mar 17, 2025

Please test with:
swiftlang/swift-package-manager#8210

@swift-ci please test

@bkhouri
Copy link
Contributor

bkhouri commented Mar 17, 2025

@bkhouri that sounds great! I think that I have enough on my plate and would love to get some help :)

I have swiftlang/swift-package-manager#8210 as a draft that will allow us to enforce/required the self-hosted windows pipelines, which we can then work on re-enabling the skipped tests on windows. Once the Windows self-hosted pipeline is marked required, we can then work on enabling the Swift PM tests in the Swift PM PR Windows platform build

@bkhouri
Copy link
Contributor

bkhouri commented Mar 28, 2025

Please test with
swiftlang/swift-package-manager#8210

@swift-ci please test

@bkhouri
Copy link
Contributor

bkhouri commented Mar 31, 2025

@swift-ci please test

@bkhouri
Copy link
Contributor

bkhouri commented Mar 31, 2025

@compnerd : I created #80405 as I did not have permissions to push to your branch to resolve the merge conflicts. I'm happy to continue trying to enable the Swift PM test in the Windows platform builds in this PR -if you want to grant me push access to the branch, or I can continue in my fork. Please let me know if you have any preference.

@compnerd compnerd closed this Apr 7, 2025
@compnerd compnerd deleted the spm-validation branch April 7, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants