-
Notifications
You must be signed in to change notification settings - Fork 10.5k
utils: enable SPM self-hosted test suite on Windows #71349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test Windows platform |
@swift-ci please test Windows platform |
34e2d8b
to
2052298
Compare
@swift-ci please test Windows platform |
2052298
to
09ee518
Compare
Please test with following PRs: @swift-ci please test Windows platform |
@swift-ci please test |
@swift-ci Please test Windows platform |
This will enable the SPM test suite to be built with a self-hosted build to ensure that we do not regress the SPM builds on Windows.
Thanks for this PR @compnerd . I was planning on tackling this once I finished swiftlang/swift-package-manager#8176. But I'm happy to see you progressing on this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, though I'm not familiar enough with the utils/build-windows-toolchain.bat
to approve this PR.
@bkhouri that sounds great! I think that I have enough on my plate and would love to get some help :) |
Please test with: @swift-ci please test |
I have swiftlang/swift-package-manager#8210 as a draft that will allow us to enforce/required the self-hosted windows pipelines, which we can then work on re-enabling the skipped tests on windows. Once the Windows self-hosted pipeline is marked required, we can then work on enabling the Swift PM tests in the Swift PM PR Windows platform build |
Please test with @swift-ci please test |
@swift-ci please test |
@compnerd : I created #80405 as I did not have permissions to push to your branch to resolve the merge conflicts. I'm happy to continue trying to enable the Swift PM test in the Windows platform builds in this PR -if you want to grant me push access to the branch, or I can continue in my fork. Please let me know if you have any preference. |
This will enable the SPM test suite to be built with a self-hosted
build to ensure that we do not regress the SPM builds on Windows.