Skip to content

Tests: enable Swift PM tests in Windows toolchain build #80405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Mar 31, 2025

Enable the SwiftPM tests in the Windows toolchain build to get extra confidence the change did not introduce any regression on the Windows platform.

Requires: swiftlang/swift-package-manager#8601

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 8, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 8, 2025

@swift-ci test macOS

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 8, 2025

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 8, 2025

duplicate of #71349 (I did not have permissions to update the source branch)

@bkhouri bkhouri marked this pull request as ready for review April 8, 2025 20:26
@bkhouri bkhouri requested a review from compnerd as a code owner April 8, 2025 20:26
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as CI is happy, I think that this is good

@bkhouri bkhouri enabled auto-merge April 9, 2025 19:14
@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 10, 2025

@swift-ci test windows

Enable the SwiftPM tests in the WIndows toolchain build to get extra
confidence the change did not introduce any regression on the Windows
platform.
@bkhouri bkhouri force-pushed the t/main/update_swiftpm_presets branch from 3516197 to ca0787f Compare April 21, 2025 17:55
@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 21, 2025

@swift-ci please smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 22, 2025

@compnerd : enabling the swiftpm tests in the build.ps1 has some test failures, which are not observed with the self hosted windows pipeline, which run inside a docker image.

Do you have any thoughts/ideas why the two would be different, and how we can closer align the test status between the two?

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 27, 2025

@swift-ci smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 28, 2025

@swift-ci please smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented Apr 29, 2025

@swift-ci smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented May 1, 2025

bkhouri added a commit to swiftlang/swift-package-manager that referenced this pull request May 1, 2025
The Archiver tests has a dependency on a system binary being available
on the host. Update the archiver test to skip the test is the required
executable is not available on the system.

Fixes: #8586
Issue: rdar://150414402
Required for: swiftlang/swift#80405
@bkhouri
Copy link
Contributor Author

bkhouri commented May 15, 2025

@swift-ci smoke test

@bkhouri
Copy link
Contributor Author

bkhouri commented May 16, 2025

@swift-ci smoke test windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants