-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] make swiftinterfaces compatible with older toolchains #72365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please smoke test |
53b1e92
to
8459d06
Compare
@swift-ci please smoke test |
tshortli
approved these changes
Mar 15, 2024
Thanks! |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked `@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so that use of these entry points from other `rethrows` functions is accepted. Builds on swiftlang#72365. Once we no longer have to support pre-`$TypedThrows` compilers, all of this can be reverted. Part of rdar://125138945
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked `@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so that use of these entry points from other `rethrows` functions is accepted. Builds on swiftlang#72365. Once we no longer have to support pre-`$TypedThrows` compilers, all of this can be reverted. Part of rdar://125138945
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked `@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so that use of these entry points from other `rethrows` functions is accepted. Builds on swiftlang#72365. Once we no longer have to support pre-`$TypedThrows` compilers, all of this can be reverted. Part of rdar://125138945
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked `@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so that use of these entry points from other `rethrows` functions is accepted. Builds on swiftlang#72365. Once we no longer have to support pre-`$TypedThrows` compilers, all of this can be reverted. Part of rdar://125138945
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked `@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so that use of these entry points from other `rethrows` functions is accepted. Builds on swiftlang#72365. Once we no longer have to support pre-`$TypedThrows` compilers, all of this can be reverted. Part of rdar://125138945
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked `@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so that use of these entry points from other `rethrows` functions is accepted. Builds on swiftlang#72365. Once we no longer have to support pre-`$TypedThrows` compilers, all of this can be reverted. Part of rdar://125138945
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked `@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so that use of these entry points from other `rethrows` functions is accepted. Builds on swiftlang#72365. Once we no longer have to support pre-`$TypedThrows` compilers, all of this can be reverted. Part of rdar://125138945
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Mar 28, 2024
Functions that are used in public `@inlinable` function bodies can't be marked `@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so that use of these entry points from other `rethrows` functions is accepted. Builds on swiftlang#72365. Once we no longer have to support pre-`$TypedThrows` compilers, all of this can be reverted. Part of rdar://125138945
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid failures when toolchains without typed throws are used