Skip to content

[stdlib] make swiftinterfaces compatible with older toolchains #72365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

glessard
Copy link
Contributor

Avoid failures when toolchains without typed throws are used

@glessard glessard requested a review from a team as a code owner March 15, 2024 22:54
@glessard
Copy link
Contributor Author

@swift-ci please smoke test

@glessard glessard requested review from DougGregor, Azoy, tshortli and a team and removed request for a team March 15, 2024 22:54
@glessard glessard force-pushed the rethrowing-disappearing-act branch from 53b1e92 to 8459d06 Compare March 15, 2024 23:50
@glessard
Copy link
Contributor Author

@swift-ci please smoke test

@tshortli
Copy link
Contributor

Thanks!

@glessard glessard changed the title [stdlib] preserve untyped-throws versions of functions [stdlib] make swiftinterfaces compatible with older toolchains Mar 15, 2024
@glessard glessard enabled auto-merge March 15, 2024 23:55
@glessard glessard merged commit d00866a into swiftlang:main Mar 16, 2024
tshortli added a commit to tshortli/swift that referenced this pull request Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked
`@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so
that use of these entry points from other `rethrows` functions is accepted.

Builds on swiftlang#72365. Once we no longer have to
support pre-`$TypedThrows` compilers, all of this can be reverted.

Part of rdar://125138945
tshortli added a commit to tshortli/swift that referenced this pull request Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked
`@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so
that use of these entry points from other `rethrows` functions is accepted.

Builds on swiftlang#72365. Once we no longer have to
support pre-`$TypedThrows` compilers, all of this can be reverted.

Part of rdar://125138945
tshortli added a commit to tshortli/swift that referenced this pull request Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked
`@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so
that use of these entry points from other `rethrows` functions is accepted.

Builds on swiftlang#72365. Once we no longer have to
support pre-`$TypedThrows` compilers, all of this can be reverted.

Part of rdar://125138945
tshortli added a commit to tshortli/swift that referenced this pull request Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked
`@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so
that use of these entry points from other `rethrows` functions is accepted.

Builds on swiftlang#72365. Once we no longer have to
support pre-`$TypedThrows` compilers, all of this can be reverted.

Part of rdar://125138945
tshortli added a commit to tshortli/swift that referenced this pull request Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked
`@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so
that use of these entry points from other `rethrows` functions is accepted.

Builds on swiftlang#72365. Once we no longer have to
support pre-`$TypedThrows` compilers, all of this can be reverted.

Part of rdar://125138945
tshortli added a commit to tshortli/swift that referenced this pull request Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked
`@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so
that use of these entry points from other `rethrows` functions is accepted.

Builds on swiftlang#72365. Once we no longer have to
support pre-`$TypedThrows` compilers, all of this can be reverted.

Part of rdar://125138945
tshortli added a commit to tshortli/swift that referenced this pull request Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked
`@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so
that use of these entry points from other `rethrows` functions is accepted.

Builds on swiftlang#72365. Once we no longer have to
support pre-`$TypedThrows` compilers, all of this can be reverted.

Part of rdar://125138945
tshortli added a commit to tshortli/swift that referenced this pull request Mar 28, 2024
Functions that are used in public `@inlinable` function bodies can't be marked
`@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so
that use of these entry points from other `rethrows` functions is accepted.

Builds on swiftlang#72365. Once we no longer have to
support pre-`$TypedThrows` compilers, all of this can be reverted.

Part of rdar://125138945
@glessard glessard deleted the rethrowing-disappearing-act branch February 26, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants