stdlib: Make typed throws ABI placeholders properly @usableFromInline
#72612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
typed-throws-condfails
branch
from
92fc905 to
4f4714e
Compare
|
@swift-ci please smoke test |
DougGregor
approved these changes
Mar 27, 2024
Functions that are used in public `@inlinable` function bodies can't be marked `@_spi` nor can they be made obsolete. Also, they must retain `rethrows` so that use of these entry points from other `rethrows` functions is accepted. Builds on swiftlang#72365. Once we no longer have to support pre-`$TypedThrows` compilers, all of this can be reverted. Part of rdar://125138945
tshortli
force-pushed
the
typed-throws-condfails
branch
from
4f4714e to
a1dacc1
Compare
|
@swift-ci please smoke test |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Jul 8, 2024
swiftlang#72612 can be reverted because it is no longer necessary for the interface of the stdlib to be compatible with compilers without `$TypedThrows` support.
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Jul 8, 2024
swiftlang#72612 can be reverted because it is no longer necessary for the interface of the stdlib to be compatible with compilers without `$TypedThrows` support.
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Jul 8, 2024
swiftlang#72612 can be reverted because it is no longer necessary for the interface of the stdlib to be compatible with compilers without `$TypedThrows` support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions that are used in public
@inlinablefunction bodies can't be marked@_spinor can they be made obsolete. Also, they must retainrethrowsso that use of these entry points from otherrethrowsfunctions is accepted.Builds on #72365. Once we no longer have to support pre-
$TypedThrowscompilers, all of this can be reverted.Part of rdar://125138945