Skip to content

Add missed case to AssignAddressToDef #72617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

Add missed case to AssignAddressToDef #72617

merged 1 commit into from
Mar 27, 2024

Conversation

asl
Copy link
Contributor

@asl asl commented Mar 27, 2024

Fixes #71744

@asl asl requested a review from aschwaighofer March 27, 2024 11:56
@asl
Copy link
Contributor Author

asl commented Mar 27, 2024

@aschwaighofer
The original swift testcase from #71744 is quite large and fragile and requires several modules compiled together + autodiff + @testable lowering enabled in order to generate the code in question. I think the change is simple enough to be reviewed w/o a testcase :)

@asl
Copy link
Contributor Author

asl commented Mar 27, 2024

Tagging @fibrechannelscsi

@asl
Copy link
Contributor Author

asl commented Mar 27, 2024

@swift-ci please test

@asl asl changed the title Add missed case to AssignAddressToDef. Add missed case to AssignAddressToDef Mar 27, 2024
aschwaighofer
aschwaighofer approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@asl asl enabled auto-merge (squash) March 27, 2024 15:00
@asl asl merged commit a63078f into main Mar 27, 2024
@asl asl deleted the 71744-fix branch March 27, 2024 17:49
@asl asl mentioned this pull request Apr 5, 2024
Merged
aschwaighofer pushed a commit to aschwaighofer/swift that referenced this pull request Sep 4, 2024
@asl @aschwaighofer
[6.0] Add missed case to AssignAddressToDef. (swiftlang#72617)
900d61a 
Fixes swiftlang#71744
Cherry-picked from a63078f

rdar://135227988
aschwaighofer added a commit to aschwaighofer/swift that referenced this pull request Sep 4, 2024
@aschwaighofer
Test for PR swiftlang#72617
4d3b6c8
aschwaighofer added a commit to aschwaighofer/swift that referenced this pull request Sep 4, 2024
@aschwaighofer
Add a test for PR swiftlang#72617
8ac5793
@aschwaighofer aschwaighofer mentioned this pull request Sep 4, 2024
Merged
aschwaighofer added a commit that referenced this pull request Sep 5, 2024
@aschwaighofer
Merge pull request #76261 from aschwaighofer/test_case_pr_72617
be9d344 
Add a test for PR #72617
aschwaighofer pushed a commit to aschwaighofer/swift that referenced this pull request Sep 13, 2024
@asl @aschwaighofer
[6.0] Add missed case to AssignAddressToDef. (swiftlang#72617)
d525bac 
Fixes swiftlang#71744
Cherry-picked from a63078f

rdar://135227988
aschwaighofer added a commit to aschwaighofer/swift that referenced this pull request Sep 13, 2024
@aschwaighofer
Test for PR swiftlang#72617
94322e1
@asl asl mentioned this pull request Oct 18, 2024
Merged
clackary pushed a commit to clackary/swift that referenced this pull request Oct 18, 2024
@asl @clackary
Add missed case to AssignAddressToDef. (swiftlang#72617)
2250314 
Fixes swiftlang#71744

(cherry picked from commit a63078f)
@clackary clackary mentioned this pull request Oct 18, 2024
Closed
clackary pushed a commit to clackary/swift that referenced this pull request Nov 5, 2024
@asl @clackary
Add missed case to AssignAddressToDef. (swiftlang#72617)
bbd3696 
Fixes swiftlang#71744

(cherry picked from commit a63078f)
(cherry picked from commit 2250314)
clackary pushed a commit to clackary/swift that referenced this pull request Nov 5, 2024
@asl @clackary
Add missed case to AssignAddressToDef. (swiftlang#72617)
30e5cd7 
Fixes swiftlang#71744

(cherry picked from commit a63078f)
@3405691582 3405691582 mentioned this pull request Jan 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschwaighofer aschwaighofer aschwaighofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LoadableByAddr] unchecked_bitwise_cast error.
2 participants
@asl @aschwaighofer