-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Ensure LoadableByAddress rewrites pointer_to_address #72619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dress is address of tuple type that should be rewritten. Fixes #72363
Tagging @fibrechannelscsi |
@swift-ci Please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
@aschwaighofer By the way, the issue does exist in Swift 6 release branch. So you might want to backport the fix there (as well as #72617). I believe we do have some other LoadableByAddress-related issues, but no reduced reproducer and / or fix yet :) |
Was this ever cherry-picked to the 6.0 branch? If not, please put up a separate PR to merge to release/6.0 with this change. Likewise for #72617. (For the record, this late in the release process, each main PR should have a separate cherry-pick PR.) |
I have not done any cherry-picks as I do not know what is the policy for fixes similar to this one. This is why I left for @aschwaighofer to decide if this should be backported or not. |
if the target address is address of tuple type that should be rewritten. Fixes swiftlang#72363 (cherry picked from commit 2ad4a60)
if the target address is address of tuple type that should be rewritten. Fixes swiftlang#72363 (cherry picked from commit 2ad4a60)
if the target address is address of tuple type that should be rewritten. Fixes swiftlang#72363 (cherry picked from commit 2ad4a60) (cherry picked from commit 1457fe6)
if the target address is address of tuple type that should be rewritten. Fixes swiftlang#72363 (cherry picked from commit 2ad4a60)
The cases here is the target address is an address of tuple type that should be rewritten.
Fixes #72363