Skip to content

Ensure LoadableByAddress rewrites pointer_to_address #72619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Ensure LoadableByAddress rewrites pointer_to_address #72619

merged 1 commit into from
Mar 27, 2024

Conversation

asl
Copy link
Contributor

@asl asl commented Mar 27, 2024

The cases here is the target address is an address of tuple type that should be rewritten.

Fixes #72363

…dress is

address of tuple type that should be rewritten.

Fixes #72363
@asl asl requested a review from aschwaighofer March 27, 2024 13:55
@asl
Copy link
Contributor Author

asl commented Mar 27, 2024

Tagging @fibrechannelscsi

@asl
Copy link
Contributor Author

asl commented Mar 27, 2024

@swift-ci Please test

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@asl asl enabled auto-merge (squash) March 27, 2024 15:00
@asl asl merged commit 2ad4a60 into main Mar 27, 2024
@asl asl deleted the 72363-fix branch March 27, 2024 19:12
@asl
Copy link
Contributor Author

asl commented Apr 5, 2024

@aschwaighofer By the way, the issue does exist in Swift 6 release branch. So you might want to backport the fix there (as well as #72617). I believe we do have some other LoadableByAddress-related issues, but no reduced reproducer and / or fix yet :)

@tbkka
Copy link
Contributor

tbkka commented Jun 27, 2024

Was this ever cherry-picked to the 6.0 branch? If not, please put up a separate PR to merge to release/6.0 with this change. Likewise for #72617. (For the record, this late in the release process, each main PR should have a separate cherry-pick PR.)

@asl
Copy link
Contributor Author

asl commented Jun 27, 2024

Was this ever cherry-picked to the 6.0 branch? If not, please put up a separate PR to merge to release/6.0 with this change. Likewise for #72617. (For the record, this late in the release process, each main PR should have a separate cherry-pick PR.)

I have not done any cherry-picks as I do not know what is the policy for fixes similar to this one. This is why I left for @aschwaighofer to decide if this should be backported or not.

clackary pushed a commit to clackary/swift that referenced this pull request Oct 18, 2024
if the target address is address of tuple type that should be rewritten.

Fixes swiftlang#72363

(cherry picked from commit 2ad4a60)
clackary pushed a commit to clackary/swift that referenced this pull request Nov 4, 2024
if the target address is address of tuple type that should be rewritten.

Fixes swiftlang#72363

(cherry picked from commit 2ad4a60)
clackary pushed a commit to clackary/swift that referenced this pull request Nov 5, 2024
if the target address is address of tuple type that should be rewritten.

Fixes swiftlang#72363

(cherry picked from commit 2ad4a60)
(cherry picked from commit 1457fe6)
clackary pushed a commit to clackary/swift that referenced this pull request Nov 5, 2024
if the target address is address of tuple type that should be rewritten.

Fixes swiftlang#72363

(cherry picked from commit 2ad4a60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LoadableByAddr] Assertion failed: (srcAddr->getType() == destAddr->getType())
3 participants