[Concurrency] Remove -disable-region-based-isolation-with-strict-concurrency.
#74567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-concurrency` from tests.
…concurrency` flag.
ktoso
approved these changes
Jun 20, 2024
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was used as a staging mechanism for enabling
RegionBasedIsolationby default under-strict-concurrency=completewithout having to update all of the tests, and it's only available in asserts compiler builds. Now that SE-0414 is implemented for Swift 6.0, it's not valuable to continue to run tests without it, and removing the flag is helpful for moving forward with improvements to the concurrency diagnostics without needing to handle test configurations that users will never experience.