Skip to content

[6.0][Concurrency] Remove -disable-region-based-isolation-with-strict-concurrency. #74579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2024
Merged

[6.0][Concurrency] Remove -disable-region-based-isolation-with-strict-concurrency. #74579

merged 2 commits into from
Jun 21, 2024

Conversation

hborla
Copy link
Member

@hborla hborla commented Jun 20, 2024

  • Explanation: The -disable-region-based-isolation-with-strict-concurrency flag was used as a staging mechanism for enabling RegionBasedIsolation by default under -strict-concurrency=complete without having to update all of the tests, and it's only available in asserts compiler builds. Now that SE-0414 is implemented for Swift 6.0, it's not valuable to continue to run tests without it, and removing the flag is helpful for moving forward with improvements to the concurrency diagnostics without needing to handle test configurations that users will never experience.
  • Scope: Does not impact the user-facing language. Removes a flag that was only used for testing purposes in asserts compiler builds.
  • Issue: N/A
  • Risk: None. This is effectively a test-only change.
  • Testing: Updated existing tests.
  • Reviewer: @ktoso
  • Main branch PR: [Concurrency] Remove -disable-region-based-isolation-with-strict-concurrency. #74567

hborla added 2 commits June 20, 2024 10:35
@hborla
[NFC][Concurrency] Remove `-disable-region-based-isolation-with-stric…
78d1f52 
…t-concurrency`

from tests.

(cherry picked from commit 1a07152)
@hborla
[Concurrency] Remove the `disable-region-based-isolation-with-strict-…
7ea1c9f 
…concurrency`

flag.

(cherry picked from commit de78fd4)
@hborla hborla requested a review from a team as a code owner June 20, 2024 17:44
@hborla
Copy link
Member Author

hborla commented Jun 20, 2024

@swift-ci please test

@hborla hborla merged commit 14d08b5 into swiftlang:release/6.0 Jun 21, 2024
5 checks passed
@hborla hborla deleted the 6.0-remove-disable-region-isolation branch June 21, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hborla @nkcsgexi @shahmishal