[Package CMO] Require library-evolution flag. #76278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsh
requested review from
eeckstein,
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
elsh
force-pushed
the
elsh/pcmo-diags
branch
from
f94f864 to
e77fca6
Compare
This PR ensures library-evolution is enabled for Package CMO; without it, it previously fell back to regular CMO, which caused mismatching serialization attributes if importing another module that had Package CMO enbaled, causing an assert fail for loadable types. Resolves rdar://135308288
elsh
force-pushed
the
elsh/pcmo-diags
branch
from
e77fca6 to
66b504a
Compare
|
@swift-ci smoke test |
nkcsgexi
reviewed
Sep 5, 2024
| if (M.getSwiftModule()->isResilient() && | ||
| !M.getSwiftModule()->serializePackageEnabled()) | ||
| if (M.getSwiftModule()->serializePackageEnabled()) { | ||
| assert(M.getSwiftModule()->isResilient() && |
There was a problem hiding this comment.
In addition to the assert, we should also return when M is resilient.
There was a problem hiding this comment.
yup it's in the else if line below
nkcsgexi
reviewed
Sep 5, 2024
Update tests
|
@swift-ci smoke test |
elsh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures library-evolution is enabled for Package CMO; without it, it previously fell back to regular CMO, which caused mismatching serialization attributes if importing another module that had Package CMO enbaled, causing an assert fail for loadable types.
Resolves rdar://135308288&135276295