[6.1][CMake] Fix package CMO capability checking logic #79901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bnbarham
commented
Mar 11, 2025
bnbarham
commented
- Explanation: The host swift-syntax is missing package CMO since [Package CMO] Require library-evolution flag. #76278, which results in a significant regression to build performance for anything using these libraries.
- Scope: Host swift-syntax libraries
- Issues: rdar://146673779
- Original PRs: [CMake] Fix package CMO capability chekcing logic #79884
- Risk: Very low, we were already building in this configuration for all of release/6.0 (and still do for any 6.0 compiler)
- Testing: Build + compiler tests with 6.1 host
- Reviewers: @hborla
Package CMO requires '-enable-library-evolution' in 6.1+ compilers. Otherwise: <unknown>:0: error: Library evolution must be enabled for Package CMO rdar://146673779 (cherry picked from commit 860ea2c)
bnbarham
force-pushed
the
6.1-syntax-cmo
branch
from
944ab09 to
ff64d67
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Mar 11, 2025
bnbarham
changed the title
bnbarham
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.