[build.ps1] don't use host Python any more #76594
Conversation
| } catch { | ||
| Write-Output "Installing pip ..." | ||
| Invoke-Program -OutNull $Python '-I' -m ensurepip -U --default-pip | ||
| } |
There was a problem hiding this comment.
Is there a way to just perform the installation assuming it is not present without any adverse effects?
There was a problem hiding this comment.
I don’t think that’s a good idea, but it’s certainly doable.
There was a problem hiding this comment.
Had a simple try and found that we cannot easily reuse Extract-ZipFile because Expand-Archive requires .zip as file extension, and wheels aren’t extracted to standalone directories. Given that pip is already included (no download required) and simply just not installed, it shouldn’t be a real problem.
There was a problem hiding this comment.
I think that using pip is fine, just trying to see if we can simplify some of the logic here by just unconditionally doing python -I -m ensurepip -U --default-pip.
There was a problem hiding this comment.
Running conditionally should work, but I intended to log precisely about what’s happening. Also need to notice that this command will output some noise when you already have pip installed.
There was a problem hiding this comment.
Thanks for working on this @stevapple! The move away from host Python solved an issue for me accessing modules in LLDB tests. And I can re-use your approach for installing modules: 942538f What else do you think will be necessary to merge this PR?
There was a problem hiding this comment.
@weliveindetail Glad to hear that it helped you! Let’s wait for @compnerd to kick off a new CI run and see if there’s any other problem.
There was a problem hiding this comment.
Great. Then I will wait for it to land, rebase my changes on top of it and add my Python modules for lldb tests. Maybe I will have to factor out a function or so, that would be no problem to do. What do you think @compnerd?
|
@swift-ci please test Windows platform |
|
Although a workaround is applied, I do think we were misusing |
|
@swift-ci please test Windows platform |
|
@swift-ci please test |
|
@stevapple Are you fine to merge this? |
Ofc, let's go ahead:) |
Cherrypick commit swiftlang#76594
Cherrypick commit swiftlang#76594
Per request of #76568 (comment), this PR cherry-picks d7057c9 which replaces the use of host Python with the cached version.