Skip to content

AST/Sema: Sink AvailabilityContext lookup queries from Sema to AST #80040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 16, 2025

Conversation

tshortli
Copy link
Contributor

Push AvailabilityScopeBuilder and the AvailabilityContext lookup functions down from Sema into AST since they don't have any strong dependencies on type checking and availability contexts would be useful for some AST queries.

NFC.

@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli tshortli merged commit da31340 into swiftlang:main Mar 16, 2025
5 checks passed
@tshortli tshortli deleted the sink-availability-scope-builder branch March 16, 2025 15:39
@hjyamauchi
Copy link
Contributor

hjyamauchi commented Mar 17, 2025

@tshortli The windows CI started to break #80058
Based on the timing, this commit may be related. CC @tshortli

tshortli added a commit to tshortli/swift that referenced this pull request Apr 3, 2025
The changes in swiftlang#80040 caused the
compiler to start diagnosing extensions containing only members that are
either `@_spi`, `@_alwaysEmitIntoClient`, or unavailable when the
`-require-explicit-availability` flag is passed. Extensions should not be
diagnosed when they only contain members that would not be diagnosed
themselves.

Resolves rdar://148275432.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants