Skip to content

Sema: Fix a regression in -require-explicit-availability diagnostics #80481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Apr 3, 2025

The changes in #80040 caused the compiler to start diagnosing extensions containing only members that are either @_spi, @_alwaysEmitIntoClient, or unavailable when the -require-explicit-availability flag is passed. Extensions should not be diagnosed when they only contain members that would not be diagnosed themselves.

Resolves rdar://148275432.

The changes in swiftlang#80040 caused the
compiler to start diagnosing extensions containing only members that are
either `@_spi`, `@_alwaysEmitIntoClient`, or unavailable when the
`-require-explicit-availability` flag is passed. Extensions should not be
diagnosed when they only contain members that would not be diagnosed
themselves.

Resolves rdar://148275432.
@tshortli
Copy link
Contributor Author

tshortli commented Apr 3, 2025

@swift-ci please smoke test

@tshortli tshortli enabled auto-merge April 3, 2025 00:13
@tshortli tshortli merged commit 0c5fd6a into swiftlang:main Apr 3, 2025
3 checks passed
@tshortli tshortli deleted the require-explicit-availability-extension-with-spi branch April 3, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant