Suppress lld assertion warnings temporarily #1873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
changed the title
MaxDesiatov
approved these changes
Sep 30, 2020
|
BTW, this only fixes the issue in development snapshots, do we ship self-built |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find the root reason why wasm-ld warns reloc validation, but I found why the warnings were suddenly appeared.
After #1582 merged, our toolchain started to use self-built wasm-ld instead of wasi-sdk's version to sync LLVM version between compiler and linker. But the wasm-ld is built with
LLVM_ENABLE_ASSERTIONS=true, so it verifies reloc records while linking.I disabled runtime assertions temporarily. I suspect that LLVM backend put invalid offset on relocation point.
Resolve #1823