Disable assertion for both target and host toolchain #1878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think that merging this into the 5.3 branch would fix |
|
I checked the built toolchain in my last PR #1873, but it still reports warnings. This PR is targeting "swiftwasm" branch and after merging this, I'll apply the patches for 5.3. |
kateinoigakukun
force-pushed
the
katei/suppress-wasm-ld-warnings-again
branch
from
d340d4a to
a7735e0
Compare
MaxDesiatov
previously approved these changes
Oct 1, 2020
kateinoigakukun
force-pushed
the
katei/suppress-wasm-ld-warnings-again
branch
2 times, most recently
from
8ab73d1 to
94d960e
Compare
kateinoigakukun
force-pushed
the
katei/suppress-wasm-ld-warnings-again
branch
from
94d960e to
f0faf22
Compare
MaxDesiatov
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.