Skip to content

Upgrading docs to Symfony 4.0 #7809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
12 tasks done
javiereguiluz opened this issue Apr 15, 2017 · 3 comments
Closed
12 tasks done

Upgrading docs to Symfony 4.0 #7809

javiereguiluz opened this issue Apr 15, 2017 · 3 comments
Milestone

Comments

@javiereguiluz
Copy link
Member

javiereguiluz commented Apr 15, 2017

This meta-issue lists all the big changes needed to upgrade the docs to Symfony 4.0:

  • Replace kernel.root_dir by kernel.project_dir everywhere. Never explain kernel.root_dir but maybe add a note mentioning that project_dir didn't exist before 4.x and people used root_dir.
  • The file extension of YAML files is now .yaml instead of .yml
  • In YAML files, null values are represented as null instead of ~ (change was reverted)
  • Application code is no longer stored in AppBundle or any other bundle. Bundles for own code are discouraged.
  • Lots of components/bundles (e.g. Symfony Console or MonologBundle) are not installed by default. We should add notes telling users to do: composer req console, etc.
  • We need to decide what to do with Symfony Flex aliases. For example, which command should we use to install the Symfony Console package? composer req cli, composer req console, composer require console, composer require symfony/console, etc.
  • Most config options are disabled by default. For example, the session service is not available by default because session config is commented in framework.yaml
  • See Remove Debugging Guide #8538 - make sure we mention all of the debugging commands somewhere
  • Commands are now always services, being in a Command/ directory is not important
  • remove references to symfony/framework-standard-edition
  • web/ to public/ (also see Fix server configuration for Symfony 4 #8693 (comment))
  • _controller -> controller

Remove deprecated features:

  • removed autowiring services based on the types they implement
  • removed the DefinitionDecorator class, replaced by ChildDefinition
  • removed the AutowireServiceResource class and related AutowirePass::createResourceForClass() method
  • removed LoggingFormatter, Compiler::getLoggingFormatter() and addLogMessage() class and methods, use the ContainerBuilder::log() method instead
  • removed FactoryReturnTypePass
  • removed ContainerBuilder::addClassResource(), use the addObjectResource() or the getReflectionClass() method instead.
  • removed support for top-level anonymous services
  • removed silent behavior for unused attributes and elements
  • Removed the "framework.validation.cache" configuration option. Configure the "cache.validator" service under "framework.cache.pools" instead.
  • Support for stacked errors in the ErrorHandler is deprecated and will be removed in Symfony 4.0.
@javiereguiluz javiereguiluz modified the milestone: 4.0 Apr 15, 2017
xabbuh added a commit that referenced this issue Oct 27, 2017
This PR was merged into the master branch.

Discussion
----------

[4.0] Fix default log directory name

Part of #7809

Commits
-------

46e5655 Fix default log directory name
@javiereguiluz
Copy link
Member Author

Closing because this is a too broad issue. We're already taking care of all these in multiple separate pull requests.

@weaverryan
Copy link
Member

@javiereguiluz I'm going to re-open this. This IS indeed broad. But I'd like to either check all the boxes in the description or create separate issues. For example, we have NOT removed all references to AppBundle yet on 4.0. We're still working on that :)

@weaverryan weaverryan reopened this Dec 1, 2017
weaverryan added a commit that referenced this issue Dec 3, 2017
This PR was squashed before being merged into the 4.0 branch (closes #8799).

Discussion
----------

Removing more AppBundle

This is still not all of them (and we have a few pending PR's which remove some additional ones). But this gets us *close* to all AppBundle gone.

I've even renamed some instances that are not technically problematic. That's because I want to be able to do a `git grep AppBundle` on 4.0 and higher and see *nothing*. This will make it easier to spot merge issues later.

This helps #7809.

Commits
-------

7d75ce3 Removing more AppBundle
@javiereguiluz
Copy link
Member Author

We finally checked all boxes of this meta issue ... so closing it as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants