Skip to content

Removing more AppBundle #8799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Removing more AppBundle #8799

wants to merge 3 commits into from

Conversation

weaverryan
Copy link
Member

@weaverryan weaverryan commented Dec 1, 2017

This is still not all of them (and we have a few pending PR's which remove some additional ones). But this gets us close to all AppBundle gone.

I've even renamed some instances that are not technically problematic. That's because I want to be able to do a git grep AppBundle on 4.0 and higher and see nothing. This will make it easier to spot merge issues later.

This helps #7809.

@weaverryan weaverryan changed the base branch from master to 4.0 December 1, 2017 04:04
is_bundle: false
type: annotation
dir: '%kernel.project_dir%/src/CustomerEntity'
prefix: 'App\Customer\Entity'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's part of the entity namespace shouldn't be dir: '%kernel.project_dir%/src/Customer/Entity'? or vice-versa prefix: 'App\CustomerEntity'?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rather think that it should be %kernel.project_dir%/src/Entity/Customer/.

In full:

AppCustomer:
    is_bundle: false
    type: annotation
    dir: '%kernel.project_dir%/src/Entity/Customer/'
    prefix: 'App\Entity\Customer'

@weaverryan
Copy link
Member Author

@yceruto @ricknox You guys were right - the example wasn't correct... and also wasn't a very good example. Can you look again? I put the entities for each EM into subdirectories, because I think if we use src/Entity for one EM and src/Entity/Customer for the second EM, the first EM will also map the entities in src/Entity/Customer, which we obviously do not want :)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weaverryan This looks imo. much better then the previous example and makes more sense to me.

weaverryan added a commit that referenced this pull request Dec 3, 2017
This PR was squashed before being merged into the 4.0 branch (closes #8799).

Discussion
----------

Removing more AppBundle

This is still not all of them (and we have a few pending PR's which remove some additional ones). But this gets us *close* to all AppBundle gone.

I've even renamed some instances that are not technically problematic. That's because I want to be able to do a `git grep AppBundle` on 4.0 and higher and see *nothing*. This will make it easier to spot merge issues later.

This helps #7809.

Commits
-------

7d75ce3 Removing more AppBundle
@weaverryan weaverryan closed this Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants