Skip to content

! prefix referencing template v4.0 #8761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

! prefix referencing template v4.0 #8761

wants to merge 2 commits into from

Conversation

silverbackdan
Copy link
Contributor

@weaverryan weaverryan added this to the 3.4 milestone Dec 1, 2017
linaori
linaori suggested changes Jan 26, 2018
View reviewed changes
Copy link
Contributor

@linaori linaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from 3.4 will be merged into the 4.0 and master branch. You can probably close #8762 and change this PR to remove the versionadded block I've suggested in #8760

@javiereguiluz
Copy link
Member

Closing for the same reasons explained in #8762.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linaori linaori linaori requested changes

@oallain oallain oallain approved these changes

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@silverbackdan @javiereguiluz @linaori @oallain @weaverryan @carsonbot