Instant converter #293
Closed
Instant converter #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatennis
force-pushed
the
datetimetype
branch
from
a4582cf to
df360dd
Compare
akudiyar
requested changes
Oct 25, 2022
There was a problem hiding this comment.
Thanks for the patch! LGTM, but there are a few more things not to forget about:
- Additional tests are needed with a version switch for
ConvertersWithClusterClientIT.javaandConvertersWithProxyClientIT.javatest suites - We need to add a CI pipeline with Tarantool 2.10 for these tests
...a/io/tarantool/driver/mappers/converters/object/DefaultInstantToExtensionValueConverter.java
Outdated
Show resolved
Hide resolved
...a/io/tarantool/driver/mappers/converters/object/DefaultInstantToExtensionValueConverter.java
Outdated
Show resolved
Hide resolved
akudiyar
reviewed
Oct 25, 2022
...va/io/tarantool/driver/mappers/converters/value/DefaultExtensionValueToInstantConverter.java
Show resolved
Hide resolved
anatennis
force-pushed
the
datetimetype
branch
from
408f6a9 to
5362932
Compare
akudiyar
requested changes
Oct 26, 2022
src/test/java/io/tarantool/driver/integration/ConvertersWithClusterClientIT.java
Show resolved
Hide resolved
anatennis
force-pushed
the
datetimetype
branch
from
535d77c to
423a308
Compare
anatennis
force-pushed
the
datetimetype
branch
from
423a308 to
0318593
Compare
anatennis
force-pushed
the
datetimetype
branch
from
7208398 to
0e30464
Compare
|
Will be done in #376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't forgotten about:
Related issues:
Closes #214