-
Notifications
You must be signed in to change notification settings - Fork 11
Add Datetime to Instant converter #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the hard-coded version a bit scares me
@@ -9,7 +9,7 @@ abstract class SharedTarantoolContainer { | |||
|
|||
private static final Logger logger = LoggerFactory.getLogger(SharedTarantoolContainer.class); | |||
|
|||
protected static final TarantoolContainer container = new TarantoolContainer() | |||
protected static final TarantoolContainer container = new TarantoolContainer("tarantool/tarantool:2.10.5-centos7") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to hardcode the Tarantool version like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't finished it. Just draft 🫠
e5a3030
to
9f4a7ab
Compare
Closes #214
This converter can support parsing Datetime tarantool type to java Instant. Because Instant doesn't support timezone and offset we can't support full DateTime type features.
Also to test new features we need to have variants of tarantool in CI so we did:
But we have one problem with versions. Tarantool on Docker hub has fixed patches only for 2.10 version if we speak about centos versions. Besides 2.10 versions we only can use 1.x, 2.x tags. That means the latest versions, for e.g. 1.10.15, 2.10.6. Then we have two ways:
I haven't forgotten about:
Related issues:
Closes #214