Skip to content

Fix specifying vshard sharding func #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AnaNek opened this issue Jul 22, 2022 · 0 comments · Fixed by #315
Closed

Fix specifying vshard sharding func #314

AnaNek opened this issue Jul 22, 2022 · 0 comments · Fixed by #315
Assignees
@AnaNek
Labels
bug Something isn't working

Comments

@AnaNek
Copy link
Contributor

AnaNek commented Jul 22, 2022

Starting from 0.11.0 user can specify sharding function to calculate bucket_id
with sharding func definition as a part of
DDL schema
or insert manually to the space _ddl_sharding_func.

Right now ddl has a bug tarantool/ddl#91
But even if this bug is fixed, there is also a bug on CRUD side.
Inserting manually to the space _ddl_sharding_func showed
that CRUD search vshard sharding func in _G but this
approach doesn't work with vshard case.
@AnaNek AnaNek added bug Something isn't working 1sp labels Jul 22, 2022
@AnaNek AnaNek self-assigned this Jul 22, 2022
AnaNek added a commit that referenced this issue Jul 22, 2022
@AnaNek
sharding func: fix specifying vshard sharding funcs
4920fd5 
Starting from 0.11.0 user can specify sharding func to
calculate bucket_id with sharding func definition as a part of
DDL schema or insert manually to the space `_ddl_sharding_func`.

Right now ddl fails with setting schema with vshard sharding function.
But even if this bug is fixed, there is also a bug on CRUD side.
Inserting manually to the space `_ddl_sharding_func` showed
that CRUD search vshard sharding func in `_G` but this
approach doesn't work with vshard case.

This patch allows to specify `vshard` sharding func
inserting manually to the space `_ddl_sharding_func`.

Closes #314
AnaNek added a commit that referenced this issue Jul 22, 2022
@AnaNek
sharding func: fix specifying vshard sharding funcs
6c4f6ba 
Starting from 0.11.0 user can specify sharding func to
calculate bucket_id with sharding func definition as a part of
DDL schema or insert manually to the space `_ddl_sharding_func`.

Right now ddl fails with setting schema with vshard sharding function.
But even if this bug is fixed, there is also a bug on CRUD side.
Inserting manually to the space `_ddl_sharding_func` showed
that CRUD search vshard sharding func in `_G` but this
approach doesn't work with vshard case.

This patch allows to specify `vshard` sharding func
inserting manually to the space `_ddl_sharding_func`.

Closes #314
@AnaNek AnaNek mentioned this issue Jul 22, 2022
Merged
2 tasks
AnaNek added a commit that referenced this issue Jul 27, 2022
@AnaNek
sharding func: fix specifying vshard sharding funcs
1d98a49 
Starting from 0.11.0 user can specify sharding func to
calculate bucket_id with sharding func definition as a part of
DDL schema or insert manually to the space `_ddl_sharding_func`.

Right now ddl fails with setting schema with vshard sharding function.
But even if this bug is fixed, there is also a bug on CRUD side.
Inserting manually to the space `_ddl_sharding_func` showed
that CRUD search vshard sharding func in `_G` but this
approach doesn't work with vshard case.

This patch allows to specify `vshard` sharding func
inserting manually to the space `_ddl_sharding_func`.

Closes #314
AnaNek added a commit that referenced this issue Jul 28, 2022
@AnaNek
sharding func: fix specifying vshard sharding funcs
32d670f 
Starting from 0.11.0 user can specify sharding func to
calculate bucket_id with sharding func definition as a part of
DDL schema or insert manually to the space `_ddl_sharding_func`.

Right now ddl fails with setting schema with vshard sharding function.
But even if this bug is fixed, there is also a bug on CRUD side.
Inserting manually to the space `_ddl_sharding_func` showed
that CRUD search vshard sharding func in `_G` but this
approach doesn't work with vshard case.

This patch allows to specify `vshard` sharding func
inserting manually to the space `_ddl_sharding_func`.

Closes #314
@ligurio ligurio mentioned this issue Aug 3, 2022
Merged
AnaNek added a commit that referenced this issue Aug 23, 2022
@AnaNek
sharding func: fix specifying vshard sharding funcs
90f0c71 
Starting from 0.11.0 user can specify sharding func to
calculate bucket_id with sharding func definition as a part of
DDL schema or insert manually to the space `_ddl_sharding_func`.

Right now ddl fails with setting schema with vshard sharding function.
But even if this bug is fixed, there is also a bug on CRUD side.
Inserting manually to the space `_ddl_sharding_func` showed
that CRUD search vshard sharding func in `_G` but this
approach doesn't work with vshard case.

This patch allows to specify `vshard` sharding func
inserting manually to the space `_ddl_sharding_func`.

Closes #314
AnaNek added a commit that referenced this issue Aug 25, 2022
@AnaNek
sharding func: fix specifying vshard sharding funcs
3ac0a5e 
Starting from 0.11.0 user can specify sharding func to
calculate bucket_id with sharding func definition as a part of
DDL schema or insert manually to the space `_ddl_sharding_func`.

Right now ddl fails with setting schema with vshard sharding function.
But even if this bug is fixed, there is also a bug on CRUD side.
Inserting manually to the space `_ddl_sharding_func` showed
that CRUD search vshard sharding func in `_G` but this
approach doesn't work with vshard case.

This patch allows to specify `vshard` sharding func
inserting manually to the space `_ddl_sharding_func`.

Closes #314
AnaNek added a commit that referenced this issue Aug 29, 2022
@AnaNek
sharding func: fix specifying vshard sharding funcs
a479871 
Starting from 0.11.0 user can specify sharding func to
calculate bucket_id with sharding func definition as a part of
DDL schema or insert manually to the space `_ddl_sharding_func`.

Right now ddl fails with setting schema with vshard sharding function.
But even if this bug is fixed, there is also a bug on CRUD side.
Inserting manually to the space `_ddl_sharding_func` showed
that CRUD search vshard sharding func in `_G` but this
approach doesn't work with vshard case.

This patch allows to specify `vshard` sharding func
inserting manually to the space `_ddl_sharding_func`.

Closes #314
DifferentialOrange added a commit that referenced this issue Aug 29, 2022
@DifferentialOrange
Release 0.13.0
994b050 
Overview

    The main feature of this release is the full support of vshard
    sharding functions (see ddl 1.6.2 for corresponding ddl release).

Breaking changes

    There are no breaking changes in the release.

New features

    * `crud.storage_info` function to get storages status (#229).

Bugfixes

    * Fix specifying `vshard` sharding funcs (#314).
DifferentialOrange added a commit that referenced this issue Aug 29, 2022
@DifferentialOrange
Release 0.13.0
68ceffc 
Overview

    The main feature of this release is the full support of vshard
    sharding functions (see ddl 1.6.2 for corresponding `ddl` release).

Breaking changes

    There are no breaking changes in the release.

New features

    * `crud.storage_info` function to get storages status (#229).

Bugfixes

    * Fix specifying `vshard` sharding funcs (#314).
@DifferentialOrange DifferentialOrange mentioned this issue Aug 29, 2022
Merged
DifferentialOrange added a commit that referenced this issue Aug 29, 2022
@DifferentialOrange
Release 0.13.0
029bc01 
Overview

    The main feature of this release is the full support of vshard
    sharding functions (see ddl 1.6.2 for corresponding `ddl` release).

Breaking changes

    There are no breaking changes in the release.

New features

    * `crud.storage_info` function to get storages status (#229).

Bugfixes

    * Fix specifying `vshard` sharding funcs (#314).
DifferentialOrange added a commit that referenced this issue Aug 29, 2022
@DifferentialOrange
Release 0.13.0
e4df508 
Overview

    The main feature of this release is the full support of vshard
    sharding functions (see ddl 1.6.2 for corresponding `ddl` release).

Breaking changes

    There are no breaking changes in the release.

New features

    * `crud.storage_info` function to get storages status (#229).

Bugfixes

    * Fix specifying `vshard` sharding funcs (#314).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnaNek AnaNek

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sharding func: fix specifying vshard sharding funcs tarantool/crud
2 participants
@DifferentialOrange @AnaNek