sharding func: fix specifying vshard sharding funcs
#315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnaNek
force-pushed
the
AnaNek/gh-314-fix-vshard-sharding-func
branch
from
6c4f6ba to
1d98a49
Compare
ligurio
reviewed
Jul 27, 2022
AnaNek
force-pushed
the
AnaNek/gh-314-fix-vshard-sharding-func
branch
from
1d98a49 to
32d670f
Compare
ligurio
approved these changes
Jul 29, 2022
AnaNek
force-pushed
the
AnaNek/gh-314-fix-vshard-sharding-func
branch
from
32d670f to
90f0c71
Compare
AnaNek
force-pushed
the
AnaNek/gh-314-fix-vshard-sharding-func
branch
from
90f0c71 to
3ac0a5e
Compare
Starting from 0.11.0 user can specify sharding func to calculate bucket_id with sharding func definition as a part of DDL schema or insert manually to the space `_ddl_sharding_func`. Right now ddl fails with setting schema with vshard sharding function. But even if this bug is fixed, there is also a bug on CRUD side. Inserting manually to the space `_ddl_sharding_func` showed that CRUD search vshard sharding func in `_G` but this approach doesn't work with vshard case. This patch allows to specify `vshard` sharding func inserting manually to the space `_ddl_sharding_func`. Closes #314
AnaNek
force-pushed
the
AnaNek/gh-314-fix-vshard-sharding-func
branch
from
3ac0a5e to
a479871
Compare
DifferentialOrange
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from 0.11.0 user can specify sharding func to
calculate bucket_id with sharding func definition as a part of
DDL schema or insert manually to the space
_ddl_sharding_func.Right now ddl fails with setting schema with vshard sharding function
(tarantool/ddl#91).
But even if this bug is fixed, there is also a bug on CRUD side.
Inserting manually to the space
_ddl_sharding_funcshowedthat CRUD search vshard sharding func in
_Gbut thisapproach doesn't work with vshard case.
This patch allows to specify
vshardsharding funcinserting manually to the space
_ddl_sharding_func.I didn't forget about
Closes #314