Count implementation #230
Merged
Count implementation #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
reviewed
Oct 27, 2021
Totktonada
reviewed
Oct 27, 2021
AnaNek
force-pushed
the
count-implementation
branch
from
30ec2ce to
11aec65
Compare
ligurio
suggested changes
Nov 2, 2021
There was a problem hiding this comment.
What was actually implemented in these changes?
PR description says that it closes ticket #74. Ticket 74 contains a discussion with different opinions of what and how it should be implemented. Get me right: I don't want to repeat stories that happen in another PR's and modules when developer, product manager, reviewer have different views regarding requirements.
ligurio
suggested changes
Nov 3, 2021
ligurio
suggested changes
Nov 17, 2021
ligurio
suggested changes
Nov 24, 2021
ligurio
suggested changes
Nov 24, 2021
AnaNek
force-pushed
the
count-implementation
branch
from
48af65b to
97883b0
Compare
ligurio
reviewed
Nov 29, 2021
ligurio
suggested changes
Nov 29, 2021
AnaNek
force-pushed
the
count-implementation
branch
5 times, most recently
from
7d6d6c5 to
96fb0d5
Compare
ligurio
reviewed
Dec 13, 2021
ligurio
suggested changes
Dec 13, 2021
ligurio
suggested changes
Dec 13, 2021
AnaNek
force-pushed
the
count-implementation
branch
from
616753d to
408315d
Compare
ligurio
suggested changes
Jan 12, 2022
ligurio
suggested changes
Jan 14, 2022
AnaNek
force-pushed
the
count-implementation
branch
from
408315d to
5bde6cf
Compare
AnaNek
force-pushed
the
count-implementation
branch
from
5bde6cf to
12eaee3
Compare
ligurio
suggested changes
Feb 14, 2022
AnaNek
force-pushed
the
count-implementation
branch
from
12eaee3 to
52a6a03
Compare
Totktonada
reviewed
Feb 17, 2022
Totktonada
reviewed
Feb 17, 2022
Totktonada
reviewed
Feb 17, 2022
Totktonada
reviewed
Feb 17, 2022
Totktonada
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
LGTM aside of several tiny comments above. Ok to push from me after fixes (not need to re-review).
Please, finish review with @ligurio first.
ligurio
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
LGTM aside comments left by @Totktonada and merge conflict.
Thanks for your patience!
AnaNek
force-pushed
the
count-implementation
branch
from
52a6a03 to
01054ac
Compare
For `count` implementation with the support of the query by conditions there is a need to use query plan and condition filters that has been already written for select. This commit separates common methods from select module and moves them in common folders. Part of #74
AnaNek
force-pushed
the
count-implementation
branch
from
01054ac to
4ada70e
Compare
This commit introduces count method that: * has arguments and options like `select()`/`pairs()`; * counts number of rows in space with yield by `yield_every`; * counts by any conditions. Closes #74
AnaNek
force-pushed
the
count-implementation
branch
from
4ada70e to
69babeb
Compare
DifferentialOrange
added a commit
that referenced
this pull request
Apr 8, 2022
1 task
DifferentialOrange
added a commit
that referenced
this pull request
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation of
count()methodThis patch introduces count method that:
select()/pairs();count_to_yield;Closes #74