Don't pass access_token as query parameter

[Totktonada]

https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/

• Use the Authorization header instead (@Totktonada).
• Deploy the update (@artembo).
• Create a list of commits that were not processed (tarantool and vshard) (@Totktonada).
• Redeliver corresponding payloads or create issues manually (@Totktonada).

[Totktonada]

I found two commits without tarantool/doc issues, found corresponding webhook payload and redelivered it. Got the new tarantool/doc issues:

• Ability to set timeout for transactions was implemented doc#2401
• [2pt] ability to set timeout for iproto transactions was implemented doc#2402

So the fix works.

I want to re-check that all commits has tarantool/doc issues.

Some weird scripting

Change directory to tarantool source repository, checkout latest master branch.

Collect existing doc issues:

$ export GITHUB_TOKEN=$(pass show name_of_the_token)
$ cat fetch-doc-issues.sh
#!/bin/sh

set -eux

issues_url='https://github.com/api/repos/tarantool/doc/issues?state=all&per_page=100'
page_count=$(curl -fsSI -H "Authorization: token ${GITHUB_TOKEN}" "${issues_url}" | grep '^link:' | sed -e 's/^.*&page=\([0-9]\+\)>; rel="last".*$/\1/')

for i in $(seq 1 ${page_count}); do
    curl -fsS -H "Authorization: token ${GITHUB_TOKEN}" "${issues_url}&page=${i}" > issues-${i}.json
done
$ ./fetch-doc-issues.sh

Extract titles:

$ for i in $(seq 1 1000); do if [ ! -f issues-$i.json ]; then continue; fi; jq -rM '.[] | select(.pull_request == null) | .title' < issues-$i.json; done | sed -e 's/^\[[^]]\+\] //' -e 's/^ \+//' > present-doc-issue-titles.txt

Extract titles from commit messages:

$ git log | grep '^    Title:' | sed 's/^    Title: //' > expected-doc-issue-titles.txt

For each expected title show whether we have corresponding doc issue:

$ while read line; do m="$(fgrep "$line" present-doc-issue-titles.txt | head -n 1)"; if [ "$m" = "$line" ]; then echo "EXACT: $line"; elif [ -n "$m" ]; then echo "FUZZY MATCH: $line | $m"; else echo "NO MATCH: $line"; fi ; done < expected-doc-issue-titles.txt >expected-doc-issue-titles-marked.txt

Now the list is the following (if we'll skip found issues):

$ grep -v ^EXACT: expected-doc-issue-titles-marked.txt

The rough list is the following:

• NO MATCH: Literals for INTEGER, DECIMAL and DOUBLE
  Redelivered: [2pt] Literals for INTEGER, DECIMAL and DOUBLE doc#2406
• NO MATCH: Document net.box watchers
  Dedelivered: [3pt] Document net.box watchers doc#2409
• NO MATCH: Document IPROTO watchers
  Redelivered: [3pt] Document IPROTO watchers doc#2408
• NO MATCH: Document box.watch and box.broadcast
  Redelivered: [5pt] Document box.watch and box.broadcast doc#2407
• NO MATCH: new function box.txn_id()
  Redelivered: Document box.txn_id() doc#2410
• NO MATCH: Introduced a new datetime module for timestamp and interval support
  Redelivered: [5pt] Introduced a new datetime module for timestamp and interval support doc#2411
• NO MATCH: ability to set timeout for 'fiber:join' function was implemented
  Filed manually: Ability to set timeout for 'fiber:join' function was implemented doc#2412
• NO MATCH: detailed iproto requests statistics was implemented
  Filed manually: [3pt] detailed iproto requests statistics was implemented doc#2413
• NO MATCH: Document box.stat.vinyl().regulator.blocked_writers
  Filed manually: [2pt] Document box.stat.vinyl().regulator.blocked_writers doc#2414
• NO MATCH: Drop error_marshaling_enabled session setting
  Filed manually: Drop error_marshaling_enabled session setting doc#2415
• NO MATCH: Document IPROTO_FEATURE_ERROR_EXTENSION
  Filed manually: Document IPROTO_FEATURE_ERROR_EXTENSION doc#2416
• NO MATCH: Document msgpack.cfg.encode_error_as_ext
  Filed manually: Document msgpack.cfg.encode_error_as_ext doc#2417
• NO MATCH: Document required_protocol_version/features net.box options
  Filed manually: Document required_protocol_version/features net.box options doc#2418
• NO MATCH: Document IPROTO_ID request
  Filed manually: [3pt] Document IPROTO_ID request doc#2419
• NO MATCH: getting statistics for iproto streams was implemented
  Filed manually: [2pt] getting statistics for iproto streams was implemented doc#2420
• NO MATCH: getting network statistic per thread was implemented
  Filed manually: [2pt] getting network statistic per thread was implemented doc#2421
• NO MATCH: interactive transactions was implemented over iproto streams.
  Found: [3pt] interactive transactions were implemented by means of iproto streams. doc#2310
• NO MATCH: new field in binary iproto protocol
  Found: [2pt] New field in binary iproto protocol doc#2306
• FUZZY MATCH: box.ctl.demote | Add the new box.ctl.demote() entry
  Found: [3pt] Add the new box.ctl.demote() entry doc#2278
• NO MATCH: synchronous replication changes
  Found: [replication] box.info.synchro.queue gets a new field "owner" doc#2277
• NO MATCH: digest module supports xxHash32/64
  Found: [3pt] Describe new digest module function for xxHash32/64 doc#2092
• NO MATCH: Add 'granularity' option to box.cfg{}
  Found: [3pt] Add 'slab_alloc_granularity' option to box.cfg{} doc#1911
• NO MATCH: fiber.cond():wait() throws if fiber is cancelled
  Found: [2pt] fiber.cond():wait() throws an error if fiber is cancelled doc#1671
• NO MATCH: change implicit cast for comparison
  Found: change implicit cast for assignment doc#1409
• NO MATCH: Doceument allowed index type for SQL
  Found: Document allowed index type for SQL doc#1377
• NO MATCH: document new binary protocol key and subscribe request changes
  Filed manually: [2pt] Document new binary protocol key and subscribe request changes doc#2422
• NO MATCH: Document decimal modulo operator
  Filed manually: Document decimal modulo operator doc#2423
• FUZZY MATCH: Extend module "tarantool" with the field "package" | Extend module "tarantool" with the field "package"
  Found: Extend module "tarantool" with the field "package"  doc#858
• NO MATCH: document set output lua
  Found: document \set output lua doc#839
• NO MATCH: introduce multikey indexes in memtx
  Found: Introduce multikey indexes doc#769
• NO MATCH: instr() is replaced with position()
  Filed manually: instr() is replaced with position() doc#2424
• FUZZY MATCH: box.stat.net | Document new box.stat.net fields
  Found: box.stat.net doc#727
• NO MATCH: changes in EXPLAIN and PRAGMA
  Filed manually: Changes in EXPLAIN and PRAGMA doc#2426
• NO MATCH: 'interface' http.client option
  Filed manually: [2pt] 'interface' http.client option doc#2425

[Totktonada]

Processed all missed documentation requests that I found in commit messages.