Use Authorization header to authenticate with GitHub API #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we'll see a problem in GitHub's UI, where delivered and failed webhook payloads are shown. Before this change the payload was marked as successfully delivered and only message like 'Created issue: 400' is shown in logs on Heroku. Part of #11
`access_token` query parameter does not work anymore. See https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/ Fixes #11
Gerold103
approved these changes
Nov 8, 2021
artembo
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authorizationheader for authenticating with GitHub API instead ofaccess_tokenquery parameter.See https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/ for details.
Fixes #11