This repository was archived by the owner on Apr 14, 2022. It is now read-only.
PCRE argument requires all non-null string fields #156
Assignees
Labels
bug
Something isn't working
Comments
|
It seems that graphql-lua still allows such requests, but graphiql warns when we try to add such pcre argument. |
Totktonada
added a commit
that referenced
this issue
May 26, 2018
The problem was in incorrect schema: sub-arguments of the pcre argument for non-null strings was generated as non-null that triggers a warning in GraphiQL in case when the sub-argument is omitted. Graphql-lua (graphql/core/validate.lua) does not check for this kind of inconsistency between a schema and a query, so lack of the sub-argument works as expected in test/common/pcre.test.lua. The added test with immediate sub-arguments of the pcre argument does not catch the bug, but I decided to leave it in the commit. Fixes #156.
Totktonada
added a commit
that referenced
this issue
May 26, 2018
The problem was in incorrect schema: sub-arguments of the pcre argument for non-null strings was generated as non-null that triggers a warning in GraphiQL in case when the sub-argument is omitted. Graphql-lua (graphql/core/validate.lua) does not check for this kind of inconsistency between a schema and a query, so lack of the sub-argument works as expected in test/common/pcre.test.lua. The added test with immediate sub-arguments of the pcre argument does not catch the bug, but I decided to leave it in the commit. Fixes #156.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
No description provided.
The text was updated successfully, but these errors were encountered: