This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fix GraphiQL warning on the pcre argument #157
Merged
+112
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was in incorrect schema: sub-arguments of the pcre argument for non-null strings was generated as non-null that triggers a warning in GraphiQL in case when the sub-argument is omitted. Graphql-lua (graphql/core/validate.lua) does not check for this kind of inconsistency between a schema and a query, so lack of the sub-argument works as expected in test/common/pcre.test.lua. The added test with immediate sub-arguments of the pcre argument does not catch the bug, but I decided to leave it in the commit. Fixes #156.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was in incorrect schema: sub-arguments of the pcre argument
for non-null strings was generated as non-null that triggers a warning
in GraphiQL in case when the sub-argument is omitted. Graphql-lua
(graphql/core/validate.lua) does not check for this kind of
inconsistency between a schema and a query, so lack of the sub-argument
works as expected in test/common/pcre.test.lua.
The added test with immediate sub-arguments of the pcre argument does
not catch the bug, but I decided to leave it in the commit.
Fixes #156.