Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Improve and refactor arguments generation #166

Closed
Totktonada opened this issue Jun 1, 2018 · 0 comments
Closed

Improve and refactor arguments generation #166

Totktonada opened this issue Jun 1, 2018 · 0 comments
Assignees
@Totktonada
Labels
code health Improve code readability, simplify maintenance and so on
Milestone
0.0.1

Comments

@Totktonada
Copy link
Member

Totktonada commented Jun 1, 2018 •
edited
Loading

That will allow to implement #163, #73, #46.

Possibly related problem: #120.
@Totktonada Totktonada added the code health Improve code readability, simplify maintenance and so on label Jun 1, 2018
@Totktonada Totktonada added this to the 0.0.1 milestone Jun 1, 2018
@Totktonada Totktonada self-assigned this Jun 1, 2018
Totktonada added a commit that referenced this issue Jun 1, 2018
@Totktonada
Move our own types to graphql/core/types.lua
320e98e 
Part of #166.
Totktonada added a commit that referenced this issue Jun 6, 2018
@Totktonada
Split code to modules
a2b2695 
Moves are mostly done w/o changes. There are APIs (parameters and return
values) that are subject to further refactoring.

Removed duplicate code in resolve the function for multihead
connections.

Part of #166.
@Totktonada Totktonada mentioned this issue Jun 6, 2018
Merged
Totktonada added a commit that referenced this issue Jun 6, 2018
@Totktonada
WIP: Refactor arguments generation / converting
0dc051c 
* Generate object arguments in avro-schema first.
* Generate object arguments for subrecords.
* Better implementation of schema reusage (in convert_schema/types).

TBD: make nested `update` argument fields nullable
TBD: make pcre support subrecords (#73).
TBD: support array, map, union in arguments converting

* Part of #166.
* Fixes #163 (TBD: test).
* Fixes #46 (TBD: test).

Can be followed up with fixing 2nd bullet in #73.
Totktonada added a commit that referenced this issue Jun 13, 2018
@Totktonada
Move our own types to graphql/core/types.lua
1d2d206 
Part of #166.
Totktonada added a commit that referenced this issue Jun 13, 2018
@Totktonada
Split code to modules
fb4b75e 
Moves are mostly done w/o changes. There are APIs (parameters and return
values) that are subject to further refactoring.

Removed duplicate code in resolve the function for multihead
connections.

Part of #166.
Totktonada added a commit that referenced this issue Jun 13, 2018
@Totktonada
Refactor arguments generation / converting
79d227a 
* Generate object arguments in avro-schema first.
* Generate object arguments for subrecords.
* Use full path for a GraphQL type name where possible.

* Part of #166.
* Part of #73 (2nd bullet).
* Fixes #163.
* Fixes #46.
Totktonada added a commit that referenced this issue Jun 13, 2018
@Totktonada
Refactor arguments generation / converting
cc7a97f 
* Generate object arguments in avro-schema format first.
* Generate object arguments for subrecords.
* Use full path for a GraphQL type name where possible.

* Part of #166.
* Fixes #73 (2nd bullet).
* Fixes #163.
* Fixes #46.
Totktonada added a commit that referenced this issue Jun 13, 2018
@Totktonada
Refactor arguments generation / converting
6d3b455 
* Generate object arguments in avro-schema format first.
* Generate object arguments for subrecords.
* Use full path for a GraphQL type name where possible.

Also:

* Added apidoc-lint target and added to CI.

* Part of #166.
* Fixes #73 (2nd bullet).
* Fixes #163.
* Fixes #46.
Totktonada added a commit that referenced this issue Jun 13, 2018
@Totktonada
Support union, array, map in arguments
658438b 
Fixes #166.
Totktonada added a commit that referenced this issue Jun 14, 2018
@Totktonada
Add insert / update argument tests with variables
a3ba71e 
Part of #166.
Totktonada added a commit that referenced this issue Jun 14, 2018
@Totktonada
Merge pull request #168 from tarantool/gh-166-refactor-arguments
7569a7d 
Split-up modules and refactor arguments converting
@Totktonada Totktonada mentioned this issue Jun 17, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Totktonada Totktonada

Labels
code health Improve code readability, simplify maintenance and so on
Projects
None yet
Milestone
0.0.1
Development

No branches or pull requests
1 participant
@Totktonada