Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Test record within a record #46

Closed
3 tasks done
Totktonada opened this issue Feb 15, 2018 · 5 comments
Closed
3 tasks done

Test record within a record #46

Totktonada opened this issue Feb 15, 2018 · 5 comments
Labels
prio2 testing
Milestone
0.0.1

Comments

@Totktonada
Copy link
Member

Totktonada commented Feb 15, 2018 •
edited
Loading

  • generate appropriate GraphQL types;
  • test for selecting such objects;
  • test for filtering by an internal fields using foo.bar: … or foo: {bar: …} syntax.
@Totktonada Totktonada changed the title Test record within record Test record within a record Feb 15, 2018
@Totktonada Totktonada added prio1 and removed prio2 labels Feb 20, 2018
@Totktonada
Copy link
Member Author

Set prio1 as our Solution guys have such schemes. One more case from them: having nested record name the same as the field name (to which it is nested) produces the error about the graphql type names clash.

@Totktonada Totktonada self-assigned this Feb 20, 2018
@Totktonada
Copy link
Member Author

A test case was filed within #49.

Totktonada added a commit that referenced this issue Feb 26, 2018
@Totktonada
WIP: support of nesting a record into a record
310d378 
* Fixes #46.
* Fixes #49.
@Totktonada Totktonada mentioned this issue Feb 26, 2018
Merged
Totktonada added a commit that referenced this issue Feb 27, 2018
@Totktonada
Support of nesting a record into a record
62f9673 
* Fixes #46.
* Fixes #49.
@Totktonada
Copy link
Member Author

Totktonada commented Feb 27, 2018 •
edited
Loading

The first two bullets are implemented in PR #56. The third one is not so important, so I postpone it and set prio2 for this issue.

Consider test/common/lua/test_data_nested_record.lua RUN 2 for the test case.

Totktonada added a commit that referenced this issue Feb 27, 2018
@Totktonada
Support of nesting a record into a record
050ee8e 
* Related to #46.
* Fixes #49.
@Totktonada Totktonada added prio2 and removed prio1 labels Feb 27, 2018
Totktonada added a commit that referenced this issue Feb 28, 2018
@Totktonada
Support of nesting a record into a record
efc542f 
* Related to #46.
* Fixes #49.
Totktonada added a commit that referenced this issue Feb 28, 2018
@Totktonada
Support of nesting a record into a record
2eecc27 
* Related to #46.
* Fixes #49.
Totktonada added a commit that referenced this issue Feb 28, 2018
@Totktonada
Support of nesting a record into a record
3bb0528 
* Related to #46.
* Fixes #49.
@Totktonada Totktonada removed their assignment Mar 27, 2018
@Totktonada
Copy link
Member Author

Related: #26.

@Totktonada Totktonada added this to the 0.0.1 milestone Apr 17, 2018
This was referenced Jun 1, 2018
Closed
Closed
Totktonada added a commit that referenced this issue Jun 6, 2018
@Totktonada
WIP: Refactor arguments generation / converting
0dc051c 
* Generate object arguments in avro-schema first.
* Generate object arguments for subrecords.
* Better implementation of schema reusage (in convert_schema/types).

TBD: make nested `update` argument fields nullable
TBD: make pcre support subrecords (#73).
TBD: support array, map, union in arguments converting

* Part of #166.
* Fixes #163 (TBD: test).
* Fixes #46 (TBD: test).

Can be followed up with fixing 2nd bullet in #73.
Totktonada added a commit that referenced this issue Jun 13, 2018
@Totktonada
Refactor arguments generation / converting
79d227a 
* Generate object arguments in avro-schema first.
* Generate object arguments for subrecords.
* Use full path for a GraphQL type name where possible.

* Part of #166.
* Part of #73 (2nd bullet).
* Fixes #163.
* Fixes #46.
@Totktonada
Copy link
Member Author

3rd bullet is done in PR #168.

Totktonada added a commit that referenced this issue Jun 13, 2018
@Totktonada
Refactor arguments generation / converting
cc7a97f 
* Generate object arguments in avro-schema format first.
* Generate object arguments for subrecords.
* Use full path for a GraphQL type name where possible.

* Part of #166.
* Fixes #73 (2nd bullet).
* Fixes #163.
* Fixes #46.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
prio2 testing
Projects
None yet
Milestone
0.0.1
Development

No branches or pull requests
1 participant
@Totktonada