Skip to content

Custom directives #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

no1seman
Copy link

@no1seman no1seman commented Oct 2, 2021

Add availability to add custom directives to GraphQL schema

@no1seman no1seman requested review from olegrok and Totktonada October 2, 2021 20:00
Copy link
Collaborator

@olegrok olegrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch. Please add commit message with detailed description for your changes. Also see my comments below.

@no1seman no1seman requested a review from olegrok October 3, 2021 12:45
DifferentialOrange pushed a commit that referenced this pull request Nov 17, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 .

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives

Based on PR #20 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 17, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 [2].

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives
2. https://spec.graphql.org/October2021/#sec-Schema-Introspection

Based on PR #20 by @no1seman
@DifferentialOrange
Copy link
Member

I was finishing this PR as a part of this sprint tasks. You can see reworked version in #26 . Since this PR is based on branch of no1seman/graphql which I have no access to, I have opened a new PR.

DifferentialOrange pushed a commit that referenced this pull request Nov 17, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 [2].

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives
2. https://spec.graphql.org/October2021/#sec-Schema-Introspection

Based on PR #20 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 18, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 [2].

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives
2. https://spec.graphql.org/October2021/#sec-Schema-Introspection

Based on PR #20 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 18, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 [2].

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives
2. https://spec.graphql.org/October2021/#sec-Schema-Introspection

Based on PR #20 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 18, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 [2].

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives
2. https://spec.graphql.org/October2021/#sec-Schema-Introspection

Based on PR #20 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 18, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 [2].

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives
2. https://spec.graphql.org/October2021/#sec-Schema-Introspection

Based on PR #20 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 18, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 [2].

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives
2. https://spec.graphql.org/October2021/#sec-Schema-Introspection

Based on PR #20 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 19, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 [2].

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives
2. https://spec.graphql.org/October2021/#sec-Schema-Introspection

Based on PR #20 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 23, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 [2].

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives
2. https://spec.graphql.org/October2021/#sec-Schema-Introspection

Based on PR #20 by @no1seman
DifferentialOrange pushed a commit that referenced this pull request Nov 23, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 [2].

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives
2. https://spec.graphql.org/October2021/#sec-Schema-Introspection

Based on PR #20 by @no1seman
Totktonada pushed a commit that referenced this pull request Nov 30, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021
release [1]. Directives are the preferred way to extend GraphQL with
custom or experimental behavior. This patch adds support of custom
directives, as well as several location adjustments and repeatable
directive option needed for full support of custom directives.

This patch also adds introspection test for schema with custom
directives to validate schema. Introspection of schema is described in
spec #4.2 [2].

1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives
2. https://spec.graphql.org/October2021/#sec-Schema-Introspection

Based on PR #20 by @no1seman
@Totktonada
Copy link
Member

Pushed with several fixups in PR #26.

@Totktonada Totktonada closed this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants