Switch to LuLPeg, update readme and rockspec #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filonenko-mikhail
approved these changes
Dec 12, 2019
olegrok
approved these changes
Dec 12, 2019
Totktonada
reviewed
Dec 12, 2019
Totktonada
reviewed
Dec 12, 2019
It is great that the motivation of the change is explicit now, but I would like to see it right in the commit message: this way I'll able to see why things were changed w/o jumps between I would also make it explicit that Please, update the commit message and proceed (or just proceed if you're disagree with me). While we're here: will we create a merge commit for each merged PR ( Personally I prefer flat history, but let's decide based on preferences of ones who want to contribute here. |
|
BTW, I suggest to close #3 from the corresponsing commit message, because in fact your commit fixes the issue. |
We decided to switch to `lulpeg` for now. It is written in lua and appears to be more stable then lpeg, which happen to crash under tarantool (or luajit). Additional research on this topic is needed. Also, unlike lpeg, lulpeg is available in tarantool ecosystem. We may return to the topic lpeg/lulpeg later, when performance issues pops up. Removed graphql/package.lua, since there are no plans to distribute package through lit right now.
RunsFor
force-pushed
the
update-readme-and-rockspec
branch
from
bf8708b to
82e3af5
Compare
There is also a "Squash and merge" button. What about that? Docs says it uses fast-forward merge. Lets try to keep it flat, but not require it to be flat. |
|
I know, it is possible to keep short-term branches (ones where a developer working on a bug or a feature) full of intermediate changes and them squash them at once. The only reason to do so it to refraining from force pushes. However it is completely okay to force-push a short-term branch. So there are no pros in this process, only cons: unability to review changes in its final state. Aside of this, considering commits atomicity, if you squash commits before push, then you are unable to propose a patchset with more then one commit within one PR. I strongly against squashing commits before push. This approach leads to a mess in many ways and this just should not be used. Or maybe should be used only for toy projects, where no review process exists and vcs history readability is not matter at all. |
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 17, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 . 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives Based on PR #20 by @no1seman
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 17, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 17, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 18, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 18, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 18, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 18, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 18, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 19, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 23, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
DifferentialOrange
pushed a commit
that referenced
this pull request
Nov 23, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
Totktonada
pushed a commit
that referenced
this pull request
Nov 30, 2021
GraphQL custom directives was introduced in spec #3.13 in October 2021 release [1]. Directives are the preferred way to extend GraphQL with custom or experimental behavior. This patch adds support of custom directives, as well as several location adjustments and repeatable directive option needed for full support of custom directives. This patch also adds introspection test for schema with custom directives to validate schema. Introspection of schema is described in spec #4.2 [2]. 1. https://spec.graphql.org/October2021/#sec-Type-System.Directives.Custom-Directives 2. https://spec.graphql.org/October2021/#sec-Schema-Introspection Based on PR #20 by @no1seman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to switch to lulpeg for now, since it is written in lua and appears to be more stable. Unlike
lpeg,lulpegis available in tarantool ecosystem.Anyway, we may return to this later, when performance issues pops up.
Tests:
tarantool tests/runner.luagives this: