Skip to content

Setup simple CI based on GitHub Actions and fix flaky test #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2021
Merged

Setup simple CI based on GitHub Actions and fix flaky test #79

merged 3 commits into from
Dec 16, 2021

Conversation

ligurio
Copy link
Member

@ligurio ligurio commented Dec 1, 2021 •
edited
Loading

Closes #75
Fixes #73

@ligurio ligurio force-pushed the ligurio/gh-75-gh-actions branch 2 times, most recently from b8ae48c to 57e0045 Compare December 1, 2021 15:53
@ligurio ligurio requested a review from LeonidVas December 1, 2021 15:54
@ligurio ligurio force-pushed the ligurio/gh-75-gh-actions branch from 57e0045 to 208855e Compare December 1, 2021 16:09
@ligurio ligurio marked this pull request as draft December 1, 2021 16:23
@ligurio ligurio force-pushed the ligurio/gh-75-gh-actions branch from 208855e to 2e709f2 Compare December 1, 2021 16:28
@ligurio ligurio marked this pull request as ready for review December 1, 2021 16:41
@ligurio ligurio mentioned this pull request Dec 1, 2021
Merged
@ligurio ligurio force-pushed the ligurio/gh-75-gh-actions branch 3 times, most recently from 99e2629 to cf52ae6 Compare December 1, 2021 19:00
Totktonada
Totktonada reviewed Dec 2, 2021
View reviewed changes
Totktonada
Totktonada reviewed Dec 2, 2021
View reviewed changes
Totktonada
Totktonada reviewed Dec 2, 2021
View reviewed changes
Totktonada
Totktonada reviewed Dec 2, 2021
View reviewed changes
@ligurio ligurio force-pushed the ligurio/gh-75-gh-actions branch from cf52ae6 to c964b68 Compare December 2, 2021 14:23
@ligurio ligurio marked this pull request as draft December 2, 2021 14:23
@ligurio ligurio force-pushed the ligurio/gh-75-gh-actions branch 2 times, most recently from de32461 to f0139f2 Compare December 2, 2021 15:07
@ligurio ligurio marked this pull request as ready for review December 2, 2021 15:10
@ligurio ligurio requested a review from Totktonada December 2, 2021 15:10
@ligurio ligurio force-pushed the ligurio/gh-75-gh-actions branch 2 times, most recently from c8e61a0 to 88f3444 Compare December 2, 2021 15:29
@ligurio ligurio mentioned this pull request Dec 3, 2021
Merged
Totktonada
Totktonada reviewed Dec 8, 2021
View reviewed changes
Totktonada
Totktonada approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

It looks okay for me.

I'm interesting to know a bit more, so asked some questions. But feel free to proceed.

LeonidVas
LeonidVas approved these changes Dec 9, 2021
View reviewed changes
Copy link
Collaborator

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the patch.
We don't have any accepted rules for decoration of commits for all tarantool modules (as well as a uniform codestyle), but IMHO it's comfortable to use the same code style and rules as in tarantool/tarantool, and follow the rules described in https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message . Up to you.

ylobankov
ylobankov reviewed Dec 13, 2021
View reviewed changes
@ligurio ligurio force-pushed the ligurio/gh-75-gh-actions branch 2 times, most recently from d99ebb9 to f7fece1 Compare December 15, 2021 16:47
@ligurio ligurio force-pushed the ligurio/gh-75-gh-actions branch from f7fece1 to efb4640 Compare December 15, 2021 19:20
@ligurio
ci: replace Travis CI with GH Actions
0807f11 
- Added workflow for GH Actions with building and testing
- Removed Jenkinsfile, Travis CI config and old scripts for running
  testing

There are also tests that run with target 'make test-memcached-capable' and memtier
benchmark, but both blocked by [1] and [2].

1. #80
2. #81

Part of #75
@ligurio
Copy link
Member Author

ligurio commented Dec 15, 2021

Hi! Thank you for the patch.
We don't have any accepted rules for decoration of commits for all tarantool modules (as well as a uniform codestyle), but IMHO it's comfortable to use the same code style and rules as in tarantool/tarantool, and follow the rules described in https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message . Up to you.

I found only one thing that doesn't conform to recommended commit message style - absence of prefix in commit message header. Added it to all three commits. // CC: @LeonidVas

@ligurio
ci: add Luacheck integration
ce89b82 
- Add CMake target that runs Luacheck - make luacheck
- Add GH Actions workflow with Luacheck
- Fixed warnings found by Luacheck

Luacheck configuration file mostly based on recommendations from Lua
style guide [1].

1. https://www.tarantool.io/en/doc/latest/dev_guide/lua_style_guide/#luacheck

Closes #75
@ligurio ligurio force-pushed the ligurio/gh-75-gh-actions branch from efb4640 to 843c8f3 Compare December 15, 2021 19:36
@ligurio ligurio changed the title Setup simple CI based on GitHub Actions Setup simple CI based on GitHub Actions and fix flaky test Dec 16, 2021
Totktonada
Totktonada reviewed Dec 16, 2021
View reviewed changes
@ligurio ligurio force-pushed the ligurio/gh-75-gh-actions branch from 3bb4507 to 1c51a01 Compare December 16, 2021 15:09
@ligurio ligurio merged commit 297e6de into master Dec 16, 2021
@Totktonada Totktonada deleted the ligurio/gh-75-gh-actions branch December 16, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonidVas LeonidVas LeonidVas approved these changes

+2 more reviewers

@Totktonada Totktonada Totktonada approved these changes

@ylobankov ylobankov ylobankov left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up simple CI based on GitHub Actions test: binary/binary-boundary.test.py test gets stuck from time to time
4 participants
@ligurio @Totktonada @ylobankov @LeonidVas