Fix memtier: add a TAP-wrapper, bump memtier version, add to CI #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligurio
force-pushed
the
ligurio/gh-81-memtier-fix
branch
from
f7edb2a to
c0b7060
Compare
ligurio
force-pushed
the
ligurio/gh-81-memtier-fix
branch
4 times, most recently
from
e6dd84e to
87422f0
Compare
ligurio
force-pushed
the
ligurio/gh-81-memtier-fix
branch
6 times, most recently
from
4b75024 to
3e9f0ec
Compare
ligurio
changed the title
ligurio
changed the title
ligurio
force-pushed
the
ligurio/gh-81-memtier-fix
branch
3 times, most recently
from
fb63e23 to
148629a
Compare
ligurio
force-pushed
the
ligurio/gh-81-memtier-fix
branch
from
148629a to
8e13b92
Compare
- slab_alloc_arena -> memtx_memory (1.7.4+), see [1] - logger_nonblock -> log_nonblock (1.7.4+), see [2] 1. https://www.tarantool.io/en/doc/latest/reference/configuration/#confval-slab_alloc_arena 2. https://www.tarantool.io/en/doc/latest/reference/configuration/#cfg-logging-logger-nonblock-deprecated
Many changes added since 2015, see [1]. 1. https://github.com/RedisLabs/memtier_benchmark/compare/40d47a0e..820605c7 Closes #91
test-run is too old and doesn't support TAP tests. Part of #81
memtier is a benchmark made by RedisLabs for load-generation and benchmarking of NoSQL key-value databases. memtier benchmark has been added in commit 'Add memtier benchmark' (a3e2815). It was added to build, but it's run was not automated. This patch adds a test that wraps memtier benchmark and allows to run it using test-run.py or pure tarantool: $ tarantool test/bench/memtier.test.lua $ test/test-run.py bench/memtier.test.lua $ make test-memcached-bench Memtier benchmark has been enabled on CI. Closes #81
ligurio
force-pushed
the
ligurio/gh-81-memtier-fix
branch
from
8e13b92 to
49a17e5
Compare
Totktonada
reviewed
Jan 12, 2022
Totktonada
reviewed
Jan 12, 2022
|
Built-in popen is used, nice! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
Blocked by #79