Disable "Terminate All" button when no EC2 resources available

[helfi92]

Steps to reproduce:

• Navigate to http://localhost:5080/aws-provisioner
• Click on a worker type with columns filled with zero's
• Click on the EC2 Resources tab

[ariellegordon]

/claim

[ariellegordon]

This is my first bug for Mozilla! If possible, would love assistance on this issue. Thank you.

[helfi92]

Hi arielle! The first step is to have your local development setup by going over the README. Once that's done, you'll want add some logic that would disable the button when the list of ec2 resources is empty. Here's the button:

taskcluster-web/src/views/AwsProvisioner/ViewWorkerType/index.jsx

Lines 154 to 161 in f64569c

	<Button
	disabled={actionLoading}
	requiresAuth
	onClick={this.handleTerminateAllInstances}
	variant="fab"
	className={classes.terminateButton}>
	<DeleteEmptyIcon />
	</Button>

. Hope that helps :)

[helfi92]

Please let me know if I can help in any way :)

[aimenbatool]

I logged in using dummy credentials. And I am getting this error. How can I fix this error now? Are there any working credentials?
What am I suppose to do here?

[helfi92]

1. Click Logout
2. Get Taskcluster credentials by doing https://github.com/taskcluster/taskcluster-web-server#taskcluster-credentials. Once you do that in your terminal, you will see something like

export TASKCLUSTER_CLIENT_ID='mozilla-auth0/ad|Mozilla-LDAP|haali/cli'
export TASKCLUSTER_ACCESS_TOKEN='...'

3. Head over to localhost:5080 and login via manual credentials (not github)
4. Paste your Client ID and Access Token. In my case it will be mozilla-auth0/ad|Mozilla-LDAP|haali/cli and ....
5. Once you're logged in, navigate to the EC2 resources tab

Let me know if you that works or whether a different error is shown. Hope that helps.

[helfi92]

@aimenbatool This bug is assigned to @ariellegordon. Let me know if you can't find another bug in the repo, I will find you one :)

[aimenbatool]

Okay, No problem.
Can you please update me on issue #127 ?
How to reproduce this error?

[ariellegordon]

Hi guys - just configuring my environment and installing yarn. I will let you know if I need any help with the bug. Hoping to get it fixed by this weekend. Thank you @helfi92 !

[helfi92]

Hi @ariellegordon. Do you still plan on tackling this issue?

[ariellegordon]

Hi @helfi92. Thanks for checking in. So sorry about the delay, and thanks for your patience. It took me a while to set up the environment for the very first time, but I now have it running and will make a PR soon. Thanks.

[helfi92]

Glad to hear. Thank you for the update :)

[ariellegordon]

@helfi92 Hi, can you help with the Login Credentials and the JSON certificate? I ran the CLI script but I'm not seeing any kind of export variables. Thank you.

[helfi92]

@ariellegordon Have a look at the discussion in #121 (comment). Let me know if you're able to successfully login after reading it :)

[ariellegordon]

Hi @helfi92 -- thank you so much for your help. I followed those instructions but I am still not able to see TASKCLUSTER_CLIENT_ID or TASKCLUSTER_ACCESS_TOKEN after I log in using the CLI. I've attached a screenshot of what I do see.

[helfi92]

@ariellegordon Once you click on "Create Client", the terminal will show TASKCLUSTER_CLIENT_ID or TASKCLUSTER_ACCESS_TOKEN.

[ariellegordon]

@helfi92 Thank you so much. Do you happen to know how to find the JSON certificate?

[helfi92]

No need. You can leave it empty.

On Fri, Oct 5, 2018 at 4:38 PM Arielle ***@***.***> wrote: @helfi92 <https://github.com/helfi92> Thank you so much. Do you happen to know how to find the JSON certificate? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#128 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADl47yql1SJAZdPrKZmQtTuw5FkrIKiRks5uh8MzgaJpZM4W0wXz> .

-- Hassan

[ariellegordon]

Sorry, sign in appears to be disabled if I leave it empty? @helfi92

[helfi92]

Refresh the browser and try again. -- Hassan

[ariellegordon]

@helfi92 refreshing worked -thank you so much for your help!

[ariellegordon]

@helfi92 I keep getting restricted access on all AWS Provisioner Worker Type screens, and refreshing the page / removing and rebuilding the node modules does not seem to change anything. Any help would be very greatly appreciated.

[helfi92]

I just gave you the required to scopes to view worker types. Try refreshing the page and see if that works.

[ariellegordon]

It works, thank you!

[ariellegordon]

@helfi92 Hi! I have a working disabled button feature but I'm having trouble pushing to the branch. I am denied permission to push to taskcluster-web at origin/branch-name. Is there another way to push or make a PR?

[helfi92]

Does git push origin <branch-name> not work? A screenshot of what you've been trying to do would be helpful.

[ariellegordon]

Yes, exactly. My branch name is "working". Screenshot attached. Thank you.

[helfi92]

You're trying to push to the wrong remote. You'll have to create a fork of taskcluster-web and then push to that fork.

Click the fork button to create a clone of that repo under your account:

Once that's done, I think you can do something like:

git push <url> working

where <url> can be copied from https://github.com/ariellegordon/taskcluster-web (after you have forked the repo)

[ariellegordon]

Ah of course. I'm sorry, a very silly mistake. I've pushed to a branch of my forked repo and made a PR --
https://github.com/ariellegordon/taskcluster-web/tree/working-branch
The only minor change is that I had to add a .prettierrc.json and as such needed to add to the .gitignore. But obviously this can be removed if/when the branch is merged.
Thank you so much for your help @helfi92.

[helfi92]

Fixed in 50e5197.

[ariellegordon]

@helfi92 Thank you for all of your help throughout this issue! It is so greatly appreciated.

[helfi92]

My pleasure!