-
Notifications
You must be signed in to change notification settings - Fork 488
Add test case for BigInt in LiteralPropertyName #2457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rwaldron
merged 5 commits into
tc39:master
from
mysticatea:literal-property-name-bigint
Feb 20, 2020
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bb54c56
Add test case for BigInt in LiteralPropertyName
mysticatea 9808a5f
add tests from #2486
mysticatea 3db0bf7
Merge branch 'master' into literal-property-name-bigint
mysticatea 4195e3d
update tests to follow review
mysticatea b0704c3
Merge branch 'master' into literal-property-name-bigint
mysticatea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
54 changes: 54 additions & 0 deletions
54
test/language/expressions/object/literal-property-name-bigint.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
// Copyright (C) 2020 Igalia S.L, Toru Nagashima. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
|
||
/*--- | ||
description: > | ||
BigInt in LiteralPropertyName must be valid and the property name must be | ||
the string representation of the numeric value. | ||
esid: prod-PropertyName | ||
info: | | ||
PropertyName[Yield, Await]: | ||
LiteralPropertyName | ||
ComputedPropertyName[?Yield, ?Await] | ||
|
||
LiteralPropertyName: | ||
IdentifierName | ||
StringLiteral | ||
NumericLiteral | ||
|
||
NumericLiteral: | ||
DecimalLiteral | ||
DecimalBigIntegerLiteral | ||
|
||
LiteralPropertyName: NumericLiteral | ||
1. Let _nbr_ be the NumericValue of |NumericLiteral|. | ||
1. Return ! ToString(_nbr_). | ||
features: [BigInt, class, destructuring-binding, let] | ||
---*/ | ||
|
||
// Property | ||
|
||
let o = { 999999999999999999n: true }; // greater than max safe integer | ||
|
||
assert.sameValue(o["999999999999999999"], true, | ||
"the property name must be the string representation of the numeric value."); | ||
|
||
// MethodDeclaration | ||
|
||
o = { 1n() { return "bar"; } }; | ||
assert.sameValue(o["1"](), "bar", | ||
"the property name must be the string representation of the numeric value."); | ||
|
||
class C { | ||
1n() { return "baz"; } | ||
} | ||
|
||
let c = new C(); | ||
assert.sameValue(c["1"](), "baz", | ||
"the property name must be the string representation of the numeric value."); | ||
|
||
// Destructuring | ||
|
||
let { 1n: a } = { "1": "foo" }; | ||
assert.sameValue(a, "foo", | ||
"the property name must be the string representation of the numeric value."); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.