-
Notifications
You must be signed in to change notification settings - Fork 489
Add test case for BigInt in LiteralPropertyName #2457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for BigInt in LiteralPropertyName #2457
Conversation
Are there any issues I should address? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sign the CLA
I'm sorry for my late response. @rwaldron Sorry, how can I sign the CLA? Two links in that page are 404. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I asked a couple of nit changes to make test style better.
test/language/expressions/object/literal-property-name-bigint.js
Outdated
Show resolved
Hide resolved
test/language/expressions/object/literal-property-name-bigint.js
Outdated
Show resolved
Hide resolved
test/language/expressions/object/literal-property-name-bigint.js
Outdated
Show resolved
Hide resolved
@mysticatea I linked directly to the CLA in my comment, here it is again: https://tc39.es/test262-cla/. I just did a test signing and the form worked as expected. |
Thank you for your review. I updated this PR. @rwaldron Thank you. I have sent the form. That was my mistake -- One of my user scripts had affected the page badly. |
Hello.
This PR adds a test case for BigInt literals in
LiteralPropertyName
production.Productions:
LiteralPropertyName > NumericLiteral > DecimalBigIntegerLiteral
Runtime Semantics: