Skip to content

Add test case for BigInt in LiteralPropertyName #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 20, 2020

Conversation

mysticatea
Copy link
Contributor

Hello.

This PR adds a test case for BigInt literals in LiteralPropertyName production.

Productions:

LiteralPropertyName > NumericLiteral > DecimalBigIntegerLiteral

Runtime Semantics:

   LiteralPropertyName: NumericLiteral
       1. Let _nbr_ be the NumericValue of |NumericLiteral|.
       1. Return ! ToString(_nbr_).

https://tc39.es/ecma262/#sec-object-initializer-runtime-semantics-evaluation

@mysticatea
Copy link
Contributor Author

Are there any issues I should address?

Copy link
Contributor

@rwaldron rwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the CLA

@mysticatea
Copy link
Contributor Author

I'm sorry for my late response.

@rwaldron Sorry, how can I sign the CLA? Two links in that page are 404.

Copy link
Contributor

@caiolima caiolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I asked a couple of nit changes to make test style better.

@rwaldron
Copy link
Contributor

@mysticatea I linked directly to the CLA in my comment, here it is again: https://tc39.es/test262-cla/. I just did a test signing and the form worked as expected.

@mysticatea
Copy link
Contributor Author

Thank you for your review. I updated this PR.

@rwaldron Thank you. I have sent the form. That was my mistake -- One of my user scripts had affected the page badly.

@rwaldron rwaldron merged commit eab9d3b into tc39:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants